Skip to content

11.1.5 itemLink changes cause errors #1024

@Nulgar

Description

@Nulgar

Addon Version

v1.10.29

World of Warcraft Version

Retail

Describe the bug

Due the 11.1.5 changes to item quality colors, the color codes around itemLinks now contain a colon, which breaks at least two parsing functions in AdiBags that use strsplit:

  • addon.ParseItemLink for breaking up item: fields (seems to only be used when "Merge unstackable items" is active and you have 2+ instances of an unstackable item)
  • containerProto:UpdateContent which retrieves the speciesID from battlepet: links (caged pets)

There are other instances of strsplit being used on itemLinks, I haven't noticed issues from these yet, but I assume they're just more specific cases, so these should also be addressed.

I suggest to cut off the color code or rather the part of the link before item:/battlepet: instead of assuming that the color code always contains a colon, the rest of the function can then continue like unchanged.
Since this change is likely causing issues for many other addons as well, the colon in the color code might get removed again in a future patch.

Steps to reproduce

Open bags with a caged pet in the inventory, or two instances of an unstackable item with "Merge unstackable items" active.

Verification

  • I have disabled all other addons and made sure this bug is triggered only with AdiBags enabled

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions