Repository navigation
Commit 7f37580
fix(agent): make the client-side HITL hard-block self-enforcing (security)
_execute_tool's hard-block path (hitl_block_high_risk / KIM_HITL_BLOCK_HIGH_RISK)
used to `pass` straight through to tool execution, on the assumption that
the MCP server's own, separately-configured gate (a different config key —
mcp_server's hitl_risk_threshold / KIM_HITL_RISK_THRESHOLD) would
independently also classify this exact tool+args as needing approval and
pause on the ApprovalBroker. That assumption doesn't hold in general: the
server-side threshold/classification can disagree with the client-side one,
so a tool the user believed was hard-blocked could execute with a human
never actually asked.
Mechanism: whenever InteractionPolicy.before_tool() hard-blocks with an
HITL_REQUIRED message, _execute_tool now invokes the SAME resolver
_make_approval_resolver() already builds for server-originated K1 approval
requests — reusing its id generation, hitl_approval_request/result events,
preview-mode auto-accept (preview's blanket confirm_action already asked
about this exact call before _execute_tool was reached), and "no bridge ->
decline" fail-closed behavior. Only "accept"/"acceptForSession" lets
execution continue; anything else returns the blocking message, exactly
like every other policy block. There is now exactly one approval mechanism
in this process instead of two that could silently disagree. Non-HITL hard
blocks (e.g. stale/unknown element_id) are untouched — they keep returning
their message unconditionally, gated by the same "HITL_REQUIRED in message"
check the old code used to select this branch.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 56fa96a commit 7f37580
2 files changed
Lines changed: 131 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1307 | 1307 | | |
1308 | 1308 | | |
1309 | 1309 | | |
1310 | | - | |
1311 | | - | |
1312 | | - | |
1313 | | - | |
1314 | | - | |
1315 | | - | |
1316 | | - | |
1317 | | - | |
1318 | | - | |
1319 | | - | |
1320 | | - | |
1321 | | - | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
1322 | 1347 | | |
1323 | 1348 | | |
1324 | 1349 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
254 | 348 | | |
255 | 349 | | |
0 commit comments