Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharrow test crashes with utility not aligned error #18

Closed
i-am-sijia opened this issue May 29, 2024 · 1 comment · Fixed by #21
Closed

Sharrow test crashes with utility not aligned error #18

i-am-sijia opened this issue May 29, 2024 · 1 comment · Fixed by #21

Comments

@i-am-sijia
Copy link
Contributor

i-am-sijia commented May 29, 2024

Describe the bug
Benchmarking run crashes when setting sharrow to test instead of require

To Reproduce
Steps to reproduce the behavior:

  1. Change require to test in exercise.py
    sharrow="require",
  2. Run exercise.py
  3. See error

Expected behavior
The utility with vs without Sharrow should be the same or within the tolerance.

Screenshots
image

Additional context
ActivitySim: d98f776af559038e1588c7f07d58df7151965cb3
Sharrow: 5b968ae86a632ea2751ce46f251f83e5f00d05d8
ABM3: f0fbc8f

@i-am-sijia
Copy link
Contributor Author

i-am-sijia commented Jun 5, 2024

The problem is in expressions with (df.get('num_escortees', 0)>0), there are 14 of them in the tour mode choice UEC.

util_PNR_LOC_Unavailable,PNR_LOC - Unavailable,"@(df.pnr_local_available == False)|(df.get('num_escortees', 0)>0)",,,,,,,,,-999,,,,,,,,,,,,,,

By the way, the sharrow utility debugging is not working in simulation.py. It makes it harder to find the problematic expression with sharrow. I opened issue ActivitySim/activitysim#874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant