-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternatives files have inconsistent formatting #846
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed all other models' alternatives files have the alternative column named and hardcoded in source code as
alt
, but for school escorting, it isAlt
. It's probably better to keep the column name consistent asalt
, even though we are not addressing the "hardcoded" part at this moment.Originally posted by @i-am-sijia in #777 (comment)
I think we should treat this issue separately from this PR. If we change it here, it will have implications for people who are already using the model (i.e. they would have to change their alternatives file). This is larger than simply changing it here as the Alt name is coded in a couple of places in this file and I would like to keep this PR focused on the BayDAG contributions. Thus, I think we should track it in a separate and stand-alone issue. Thoughts?
Originally posted by @dhensle in #777 (comment)
The text was updated successfully, but these errors were encountered: