-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking failure with fresh new install #831
Comments
Issue Caused by update in pandera package. The pandera 0.18.3 changed textual format of warning/error messages, causing parsing errors in activitysim\activitysim\abm\models\input_checker.py. FIX: NOTE: |
It appears this crash is a result of a failure in the parsing of the error message emitted from pandera. It seems our parsing is done based on fairly detailed re-formatting of the error message. But the essence of the problem isn't anything wrong with pandera emitting the error or ActivitySim catching it, it's just failing in reformatting the message for the error log. Rather than pinning to a fixed pandera version, should we just allow ActivitySim to fall back to sending pandara's raw error message to our own log? And then we can also perhaps fix out code so the error message parse/reformat isn't so fragile. |
As they have the most knowledge about why it was written the way it was, I am assigning @dhensle or his designee from RSG to fix the input checker error message parsing so that it is compatible with pandera >= 0.18.1, and in the meantime we will pin to the compatible version of pandera. This update is not urgent but should not be forgotten. |
Describe the bug
With a fresh new installation of ActivitySim, Benchmarking run fails in the compile mode (probably also fails in sharrow and legacy mode). We tested this a few times on different machines, having the same error. Log file is attached.
activitysim.log
It was all working earlier last week, so something must have happened in the past week or two that have broken this. Hypotheses:
Since it crashed in input checker, item 2 and 3 are maybe less likely.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Run should not fail.
Screenshots
Additional context
Add any other context about the problem here. @lachlan-git please provide additional context and debugging if available.
The text was updated successfully, but these errors were encountered: