Skip to content

Commit 8eee630

Browse files
authored
πŸ‘·β€β™‚οΈ Try build in PR workflow (#146)
* πŸ‘·β€β™‚οΈ Try build in PR workflow * πŸ”§ Use recommended build settings * 🚨 Solve some compiler warnings
1 parent 878fee9 commit 8eee630

File tree

11 files changed

+42
-97
lines changed

11 files changed

+42
-97
lines changed

β€Ž.github/workflows/pr.yml

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ name: PR
33
on: [pull_request]
44

55
jobs:
6+
build:
7+
name: Test build
8+
uses: ./.github/workflows/build.yml
69
tests:
710
name: Tests
811
uses: ./.github/workflows/tests.yml

β€ŽACKategories.xcodeproj/project.pbxproj

+28-80
Large diffs are not rendered by default.

β€ŽACKategories.xcodeproj/xcshareddata/xcschemes/ACKategories.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1500"
3+
LastUpgradeVersion = "1520"
44
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "YES"

β€ŽACKategories.xcodeproj/xcshareddata/xcschemes/ACKategoriesTesting.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1510"
3+
LastUpgradeVersion = "1520"
44
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "YES"

β€ŽACKategories.xcodeproj/xcshareddata/xcschemes/Networking.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1510"
3+
LastUpgradeVersion = "1520"
44
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "YES"

β€ŽACKategories.xcodeproj/xcshareddata/xcschemes/PushNotifications.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1510"
3+
LastUpgradeVersion = "1520"
44
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "YES"

β€ŽACKategories.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

-8
This file was deleted.

β€ŽSources/ACKategoriesTesting/Networking/APIServiceMock.swift

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ public final class APIService_Mock: APIServicing {
2727
case .url(let url): return url
2828
case .path(let path):
2929
return .ackeeCZ.appendingPathComponent(path)
30+
@unknown default:
31+
fatalError("Unknown case not supposed to be called")
3032
}
3133
}()
3234

β€ŽSources/ACKategoriesTesting/Networking/NetworkMock.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Foundation
22
import Networking
33

44
@available(tvOS 13.0, iOS 13.0, watchOS 6.0, macOS 10.15, *)
5-
public final class Network_Mock: Networking {
5+
public final class Network_Mock: Network {
66
public var requestBody: (URLRequest) async throws -> HTTPResponse = { _ in .test() }
77

88
public init() {

β€ŽSources/Networking/APIService.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public final class APIService: APIServicing {
1414
}
1515

1616
private let baseURLFactory: () -> URL
17-
private let network: Networking
17+
private let network: Network
1818
private let requestInterceptors: [RequestInterceptor]
1919
private let responseInterceptors: [ResponseInterceptor]
2020

@@ -26,7 +26,7 @@ public final class APIService: APIServicing {
2626
/// - responseInterceptors: List of response interceptors, useful for logging or token refresh
2727
public init(
2828
baseURL: @autoclosure @escaping () -> URL,
29-
network: Networking,
29+
network: Network,
3030
requestInterceptors: [RequestInterceptor] = [],
3131
responseInterceptors: [ResponseInterceptor] = []
3232
) {

β€ŽSources/Networking/Networking.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ import Foundation
22

33
/// Protocol wrapping raw network requests, basically URLSession
44
@available(tvOS 13.0, iOS 13.0, watchOS 6.0, macOS 10.15, *)
5-
public protocol Networking {
5+
public protocol Network {
66
/// Send given request
77
/// - Parameter request: Request to be sent
88
/// - Returns: Received response
99
func request(_ request: URLRequest) async throws -> HTTPResponse
1010
}
1111

1212
@available(tvOS 13.0, iOS 13.0, watchOS 6.0, macOS 12.0, *)
13-
extension URLSession: Networking {
13+
extension URLSession: Network {
1414
public func request(_ request: URLRequest) async throws -> HTTPResponse {
1515
let (data, response) = try await data(for: request)
1616

0 commit comments

Comments
Β (0)