Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override exposing deploys #60

Open
hunter opened this issue May 30, 2016 · 1 comment
Open

Override exposing deploys #60

hunter opened this issue May 30, 2016 · 1 comment

Comments

@hunter
Copy link
Contributor

hunter commented May 30, 2016

Deploy stage manifests can specify LoadBalancers or Ingres Resources. These should be overridable for stages to avoid security issues (and/or extra charges in GCP)

One option may be to provide a expose boolean for the deploy stage in pipeline which does search and replace for the LoadBalancer type and replaces with a ClusterIP (An Ingres could be removed entirely?)

@madziefe
Copy link
Contributor

kontinuous expose works on non-existent service.
If service exists and will have a change on service type. kubectl apply -f on service will fail.
kubernetes/kubernetes#23651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants