Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework errorhandling #268

Open
Pacmens opened this issue Jul 16, 2021 · 2 comments
Open

Rework errorhandling #268

Pacmens opened this issue Jul 16, 2021 · 2 comments
Labels
concept Conceptual work for functionality

Comments

@Pacmens
Copy link
Collaborator

Pacmens commented Jul 16, 2021

As of right now there is a lot of stuff that can outright crash hera.

A lot of these cases there propably exists a better way of handling this.

So the goal should be to rework the error handling to actually handle some possible breaking points instead of just passing the exceptions to the top level.

@Pacmens Pacmens self-assigned this Jul 16, 2021
@Pacmens Pacmens added the concept Conceptual work for functionality label Jul 16, 2021
@Pacmens Pacmens removed their assignment Jul 16, 2021
@Pacmens
Copy link
Collaborator Author

Pacmens commented Jul 16, 2021

For now this issue is mostly ment to be a collecting container to document cases where more proper errorhandling would make sense.

It will be added to priority as soon as there is enough cases to justify the workload of reviewing everything and redefining the workflows.

@Pacmens
Copy link
Collaborator Author

Pacmens commented Jul 16, 2021

returning null if database failed. may be better to return an error. could if nothing else make a better stacktrace if deciding to throw something linked to the failedafterretryexception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Conceptual work for functionality
Projects
None yet
Development

No branches or pull requests

1 participant