Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions is bad #128

Closed
Jefferson111 opened this issue Oct 22, 2019 · 0 comments
Closed

Naming conventions is bad #128

Jefferson111 opened this issue Oct 22, 2019 · 0 comments
Assignees
@Sukrut1881 @Jefferson111 @Inno97 @hongchuan97
Labels
priority.High Must do status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Milestone
v1.4

Comments

@Jefferson111
Copy link

Need to follow naming convention here.
Think if you can categorize these commands in some way.

  • are they related to a feature? if so can you name them as Feature_<message type>_<variable>
  • are they related to a particular type of message? e.g. info, error, etc.,
  • follow a standard convention to write enums.
  • variable name for "constants" don't follow the guideline
  • woah! waay too generic. please use specific exception class

Originally posted by @okkhoy in nusCS2113-AY1920S1#71
@Jefferson111 Jefferson111 added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 22, 2019
@Jefferson111 Jefferson111 added this to the v1.3 milestone Oct 22, 2019
@Jefferson111 Jefferson111 added the priority.High Must do label Oct 22, 2019
@nus-pe-script nus-pe-script mentioned this issue Oct 22, 2019
Closed
13 tasks
@Jefferson111 Jefferson111 modified the milestones: v1.3, v1.4 Oct 29, 2019
@Jefferson111 Jefferson111 added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 29, 2019
@nus-pe-script nus-pe-script mentioned this issue Nov 5, 2019
Closed
15 tasks
@nus-pe-script nus-pe-script mentioned this issue Nov 13, 2019
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sukrut1881 Sukrut1881

@Jefferson111 Jefferson111

@Inno97 Inno97

@hongchuan97 hongchuan97

Labels
priority.High Must do status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
4 participants
@Sukrut1881 @Jefferson111 @Inno97 @hongchuan97