Skip to content

Commit 45b941e

Browse files
committed
Issue #0: Clean up extraneous logging
1 parent 817895e commit 45b941e

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/bsk_rl/data/base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,8 @@ def reward(self, new_data_dict: dict[str, Data]) -> dict[str, float]:
192192
for new_data in new_data_dict.values():
193193
self.data += new_data
194194

195-
logger.info(f"Data reward: {reward}")
195+
nonzero_reward = {k: v for k, v in reward.items() if v != 0}
196+
logger.info(f"Data reward: {nonzero_reward}")
196197
return reward
197198

198199

src/bsk_rl/gym.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232

3333

3434
class GeneralSatelliteTasking(Env, Generic[SatObs, SatAct]):
35-
3635
def __init__(
3736
self,
3837
satellites: Union[Satellite, list[Satellite]],
@@ -314,7 +313,6 @@ def _get_obs(self) -> MultiSatObs:
314313
tuple: Joint observation
315314
"""
316315
if self.generate_obs_retasking_only:
317-
318316
return tuple(
319317
(
320318
satellite.get_obs()
@@ -698,9 +696,14 @@ def step(
698696
terminated = self._get_terminated()
699697
truncated = self._get_truncated()
700698
info = self._get_info()
701-
logger.info(f"Step reward: {reward}")
702-
logger.info(f"Episode terminated: {terminated}")
703-
logger.info(f"Episode truncated: {truncated}")
699+
nonzero_reward = {k: v for k, v in reward.items() if v != 0}
700+
logger.info(f"Step reward: {nonzero_reward}")
701+
if any(terminated.values()):
702+
terminated_true = [k for k, v in terminated.items() if v]
703+
logger.info(f"Episode terminated: {terminated_true}")
704+
if any(truncated.values()):
705+
truncated_true = [k for k, v in truncated.items() if v]
706+
logger.info(f"Episode truncated: {truncated_true}")
704707
logger.debug(f"Step info: {info}")
705708
logger.debug(f"Step observation: {observation}")
706709
return observation, reward, terminated, truncated, info

0 commit comments

Comments
 (0)