[24] Move to new version of danger-js, allowing a move back to ESM for first-party rules #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
TomStrepsil
commented
Feb 11, 2025
TomStrepsil
changed the title
TomStrepsil
changed the title
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <[email protected]>
Co-authored-by: Tom Pereira <[email protected]>
TomStrepsil
pushed a commit
to TomStrepsil/web-toggle-point
that referenced
this pull request
Mar 6, 2025
TomStrepsil
added a commit
to TomStrepsil/web-toggle-point
that referenced
this pull request
Apr 10, 2025
…-toggle-point into fix/revert-danger-to-esm
TomStrepsil
force-pushed
the
fix/revert-danger-to-esm
branch
from
95a6d9f to
3d85137
Compare
paperschool
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #24
Details
Update to fixed version of
danger-js, moving the common-js code back to ESM, via removing the transpilation hack introduced when the project was open-sourced.See successful danger check run.
Scout Rule
CHANGELOG.mdCheckList
main.