Skip to content

Commit 0ba42cc

Browse files
authored
[20] Fix NextJS example "showExperiments" query string and update contributing guide (#21)
1 parent ca3f683 commit 0ba42cc

File tree

34 files changed

+247
-100
lines changed

34 files changed

+247
-100
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Issue
22

3-
[_ISSUE_ID_](https://github.com/ASOS/web-toggle-point/issues/_ISSUE_ID_)
3+
resolves #_ISSUE_ID_
44

55
## Details
66

docs/CHANGELOG.md

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,31 @@ N.B. See changelogs for individual packages, where most change will occur:
1414

1515
This log covers the [monorepo](https://en.wikipedia.org/wiki/Monorepo).
1616

17+
## [0.10.5] - 2025-03-06
18+
19+
### Fixed
20+
21+
- updated the `CONTRIBUTING.md`:
22+
- clarification regarding changes needing to be committed for the `danger:local` script to be effective
23+
- clarification regarding write access or forking being needed to open a pull request
24+
25+
### Changed
26+
27+
- updated main `README.md`:
28+
- linked to `CONTRIBUTING.md`
29+
- added link to repo discussions, alongside the issues
30+
- clarified the convention-based approach to advice
31+
- updated `pull_request_template.md` to ensure "resolves #issue" is prompted, to make sure linked issues are closed automatically with PR merges
32+
33+
### Added
34+
35+
- a `danger:local:staged` command to augment the above danger fix
36+
1737
## [0.10.4] - 2025-03-06
1838

1939
### Fixed
2040

21-
- Ensured that the registry is explicitly set, to ensure that [`@actions/setup-node`](https://github.com/actions/setup-node) honours the `NODE_AUTH_TOKEN`
41+
- ensured that the registry is explicitly set, to ensure that [`@actions/setup-node`](https://github.com/actions/setup-node) honours the `NODE_AUTH_TOKEN`
2242

2343
## [0.10.3] - 2025-02-27
2444

docs/CONTRIBUTING.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ On this project we follow mainline development (or trunk based development), and
1616

1717
Therefore you need to branch / fork from `main` and merge into `main`.
1818

19+
> [!NOTE]
20+
> To contribute a pull request, [you will need to fork the repository](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) or be given [write access](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request), so get in touch to discuss the latter!
21+
1922
### Coding style
2023

2124
Generally try to match the style and conventions of the code around your changes. Ultimately we want code that is clear, concise, consistent and easy to read.
@@ -35,6 +38,12 @@ npm run test:unit
3538
npm run test:automation
3639
npm run danger:local
3740
```
41+
> [!NOTE]
42+
> N.B. The `danger:local` script requires staged changes to be committed, otherwise you will receive the message:
43+
>
44+
> `No git changes detected between head and main`
45+
>
46+
> If you'd like to check just staged commits, you can instead run `npm run danger:local:staged`
3847
3948
## Opening a PR
4049

docs/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ A library providing a means to toggle or branch web application code.
3131

3232
### 🐬 Purpose
3333

34-
This library provides a means to toggle or branch application code.
34+
This library provides a means to toggle or branch application code at runtime, whilst mitigating the carrying costs of doing so.
3535

3636
It aims to enable low friction feature toggling [aspect/advice](https://en.wikipedia.org/wiki/Advice_(programming))[^1] in a codebase.
3737

38-
It suggests a convention-based approach to storing variant code, aiming to mitigate [boilerplate](https://en.wikipedia.org/wiki/Boilerplate_code) whilst developing new features, and reduce the friction of accepting or rejecting toggled variations, when appropriate.
38+
It suggests a convention-based approach to storing variant code, aiming to mitigate [boilerplate](https://en.wikipedia.org/wiki/Boilerplate_code) whilst developing new features, and reduce the friction of accepting or rejecting toggled variations, if and when the time arises.
3939

4040
Originally developed for experiment toggles / flags, it acts only as a means to implement a toggle point, separating any toggle router concern, so is agnostic of the type of toggle or flag.
4141

@@ -84,7 +84,7 @@ Please see separate [examples documentation](../examples/README.md).
8484

8585
### 🔜 Future Plans
8686

87-
Please see [issues](https://github.com/ASOS/web-toggle-point/issues) and please consider contributing!
87+
Please see [discussions](https://github.com/ASOS/web-toggle-point/discussions) and [issues](https://github.com/ASOS/web-toggle-point/issues), and please consider [contributing](./CONTRIBUTING.md)!
8888

8989
### 🔗 Links
9090

examples/express/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ Some example applications based on an [express](https://expressjs.com/) router
44

55
1. [animals](./src/routes/animals/README.md)
66

7-
This is a basic example using the [`webpack`](../packages/webpack/docs/README.md) package.
7+
This is a basic example using the [`webpack`](../../packages/webpack/docs/README.md) package.
88

99
2. [config](./src/routes/config/README.md)
1010

11-
This example shows the use of the [`react-pointcuts`](../packages/react-pointcuts/docs/README.md), [`features`](../packages/features/docs/README.md), [`ssr`](../packages/ssr/docs/README.md) and [`webpack`](../packages/webpack/docs/README.md) packages.
11+
This example shows the use of the [`react-pointcuts`](../../packages/react-pointcuts/docs/README.md), [`features`](../../packages/features/docs/README.md), [`ssr`](../../packages/ssr/docs/README.md) and [`webpack`](../../packages/webpack/docs/README.md) packages.

examples/express/docs/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [0.2.4] - 2024-02-07
9+
10+
### Fixed
11+
12+
- corrected some links to packages from the examples readme
13+
- removed orphan `index.js` in the animals example, this has been supplanted by `router.js`
14+
815
## [0.2.3] - 2024-12-24
916

1017
### Changed

examples/express/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "web-toggle-point-express-example",
3-
"version": "0.2.3",
3+
"version": "0.2.4",
44
"type": "module",
55
"engines": {
66
"node": ">=20.6.0"

examples/express/src/routes/animals/index.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

examples/next/docs/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [0.2.3] - 2025-02-07
9+
10+
### Fixed
11+
12+
- fixed a regression in the ability to use `?showExperiments` query in the experiments fixtures, regressed in version `0.2.0`.
13+
814
## [0.2.2] - 2024-12-24
915

1016
### Fixed

examples/next/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "web-toggle-point-next-example",
3-
"version": "0.2.2",
3+
"version": "0.2.3",
44
"private": true,
55
"type": "module",
66
"scripts": {

0 commit comments

Comments
 (0)