Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spostare asset statici da arkimapslib alle ricette #111

Open
spanezz opened this issue Mar 28, 2022 · 3 comments
Open

Spostare asset statici da arkimapslib alle ricette #111

spanezz opened this issue Mar 28, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@spanezz
Copy link
Contributor

spanezz commented Mar 28, 2022

Al momento gli asset statici sono distribuiti nel modulo python in arkimapslib/static.

Non vedo piú un buon motivo per questa cosa, e propongo di spostarli in directory static all'interno delle ricette.

@spanezz spanezz added the enhancement New feature or request label Mar 28, 2022
@edigiacomo
Copy link
Member

Posso già spostare i file da arkimapslib/static a recipes/static o bisogna fare qualche modifica al codice?

@spanezz
Copy link
Contributor Author

spanezz commented Sep 12, 2023

Giusto! Puoi già farlo direi

@edigiacomo
Copy link
Member

Nel branch issue111 ho spostato i file statici dal modulo alle ricette, ma purtroppo un test fallisce. Forse basta copiare i file shapes/Sottozone_allerta_ER.* all'interno del metodo TestFlavour.kitchen?

2023-09-19 10:08:18 INFO system.fedora36 stderr: ======================================================================
2023-09-19 10:08:18 INFO system.fedora36 stderr: ERROR: test_default_shape (tests.test_flavour.TestFlavour)
2023-09-19 10:08:18 INFO system.fedora36 stderr: ----------------------------------------------------------------------
2023-09-19 10:08:18 INFO system.fedora36 stderr: Traceback (most recent call last):
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/tests/test_flavour.py", line 99, in test_default_shape
2023-09-19 10:08:18 INFO system.fedora36 stderr:     with self.kitchen(flavours=[
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/usr/lib64/python3.10/contextlib.py", line 135, in __enter__
2023-09-19 10:08:18 INFO system.fedora36 stderr:     return next(self.gen)
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/tests/test_flavour.py", line 59, in kitchen
2023-09-19 10:08:18 INFO system.fedora36 stderr:     kitchen.load_recipes([recipe_dir])
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/arkimapslib/kitchen.py", line 51, in load_recipes
2023-09-19 10:08:18 INFO system.fedora36 stderr:     self.load_recipe_dir(path, lint=lint)
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/arkimapslib/kitchen.py", line 88, in load_recipe_dir
2023-09-19 10:08:18 INFO system.fedora36 stderr:     Input.create(
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/arkimapslib/inputs.py", line 153, in create
2023-09-19 10:08:18 INFO system.fedora36 stderr:     return impl_cls(**kw)
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/arkimapslib/inputs.py", line 261, in __init__
2023-09-19 10:08:18 INFO system.fedora36 stderr:     abspath, path = self.clean_path(path)
2023-09-19 10:08:18 INFO system.fedora36 stderr:   File "/root/rpmbuild/BUILD/arkimaps/arkimapslib/inputs.py", line 329, in clean_path
2023-09-19 10:08:18 INFO system.fedora36 stderr:     raise RuntimeError(f"{path}.shp does not exist inside {self.config.static_dir}")
2023-09-19 10:08:18 INFO system.fedora36 stderr: RuntimeError: shapes/Sottozone_allerta_ER.shp does not exist inside ['/tmp/tmptj3fhkk_/static', '/root/rpmbuild/BUILD/arkimaps/arkimapslib/static']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants