Added missing check for replay protection pointer before allocating new variable

mattgbio · mattgbio · commit c26dede1f742 · 2024-05-03T10:55:35.000+02:00
diff --git a/storage/kvstore/securestore/source/SecureStore.cpp b/storage/kvstore/securestore/source/SecureStore.cpp
@@ -290,7 +290,7 @@ int SecureStore::set_start(set_handle_t *handle, const char *key, size_t final_d
         goto fail;
     }
 
-    if (create_flags & (REQUIRE_REPLAY_PROTECTION_FLAG | WRITE_ONCE_FLAG)) {
+    if (_rbp_kv && (create_flags & (REQUIRE_REPLAY_PROTECTION_FLAG | WRITE_ONCE_FLAG))) {
         _ih->key = new char[strlen(key) + 1];
         strcpy(_ih->key, key);
     }

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ int SecureStore::set_start(set_handle_t handle, const char key, size_t final_d`
`290`	`290`	`goto fail;`
`291`	`291`	`}`
`292`	`292`
`293`		`- if (create_flags & (REQUIRE_REPLAY_PROTECTION_FLAG \| WRITE_ONCE_FLAG)) {`
	`293`	`+ if (_rbp_kv && (create_flags & (REQUIRE_REPLAY_PROTECTION_FLAG \| WRITE_ONCE_FLAG))) {`
`294`	`294`	`_ih->key = new char[strlen(key) + 1];`
`295`	`295`	`strcpy(_ih->key, key);`
`296`	`296`	`}`