Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn page programming/sector erase to default #572

Open
brianesquilona opened this issue Jan 28, 2019 · 4 comments
Open

Turn page programming/sector erase to default #572

brianesquilona opened this issue Jan 28, 2019 · 4 comments
Assignees

Comments

@brianesquilona
Copy link
Contributor

Current implementation defaults to erasing the whole flash, unless the page programming or sector erase is enabled by flash_manager_set_page_erase(true);

I think we should enable this one by default if the flash algo has support for erase_sector. If there are no objections :), I will create a PR for this.

@therealprof
Copy link

I think this has both up- and downsides. On one hand using sector erase would not wipe out unprotected bootloaders and other data by accident. On the other hand partial erase has led to leakage of sensitive information more than just once...

@flit flit added the backlog label Feb 6, 2019
@flit
Copy link
Collaborator

flit commented Mar 8, 2019

@therealprof DAPLink is used in development environment, not for production firmware updates. So there should be no real secrets on the device. A device that has security requirements for managing sensitive information or keys must have debug access locked out in the production lifecycle state, so DAPLink wouldn't be able to program flash, anyway.

@therealprof
Copy link

DAPLink is used in development environment, not for production firmware updates. So there should be no real secrets on the device.

In past times we certainly have used debug probes for production purposes.

A device that has security requirements for managing sensitive information or keys must have debug access locked out in the production lifecycle state, so DAPLink wouldn't be able to program flash, anyway.

Fair enough, though I wouldn't count on it that they always exist.

@flit
Copy link
Collaborator

flit commented Mar 9, 2019

You're absolutely right, DAPLink can and will be used in production environments. However, there's a difference between factory production and end user firmware updates. The latter is what I was talking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants