Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Currently the sidebar icon shadow looks weird when not expanded #319

Open
2 tasks done
tanishy7777 opened this issue Feb 13, 2025 · 2 comments · May be fixed by #320
Open
2 tasks done

Enhancement: Currently the sidebar icon shadow looks weird when not expanded #319

tanishy7777 opened this issue Feb 13, 2025 · 2 comments · May be fixed by #320

Comments

@tanishy7777
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

When Expanded (looks good)
Image

When collapsed (looks a bit off)
Image

The height of the background remains same even after the sidebar collapses which dosen't make sense and look a bit weird. This is because the way it is handled in the code right now is that, on the basis of the state isExpanded we are setting the opacity of the text and other properties, but the test still occupies the DOM. A better approach would be to add conditional Rendering.

Record

  • I agree to follow this project's Code of Conduct
@tanishy7777 tanishy7777 linked a pull request Feb 13, 2025 that will close this issue
Open
@red-panda3
Copy link
Contributor

#325

@tanishy7777
Copy link
Author

#325

Thanks for the PR but I have already linked a PR #320
Please check before opening any duplicate PRs to avoid duplicate effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes sidebar shadow UI for active icon tanishy7777/PictoPy
2 participants
@tanishy7777 @red-panda3