some clang-tidy enum type fixes (#1582)

these use smaller types now

Author: zingale

integration/integrator_data.H

@@ -12,7 +12,7 @@ const int INT_NEQS = NumSpec + 1;
 // -failure_tolerance <= X <= 1.0 + failure_tolerance).
 const amrex::Real species_failure_tolerance = 1.e-2_rt;
 
-enum integrator_errors {
+enum integrator_errors : std::int8_t {
     IERR_SUCCESS = 1,
     IERR_BAD_INPUTS = -1,
     IERR_DT_UNDERFLOW = -2,

interfaces/eos_type.H

@@ -398,26 +398,28 @@ std::ostream& operator<< (std::ostream& o, T const& eos_state)
     return print_state(o, eos_state);
 }
 
-enum eos_input_t {eos_input_rt = 0,
-                  eos_input_rh,
-                  eos_input_tp,
-                  eos_input_rp,
-                  eos_input_re,
-                  eos_input_ps,
-                  eos_input_ph,
-                  eos_input_th};
+enum eos_input_t : std::uint8_t {
+    eos_input_rt = 0,
+    eos_input_rh,
+    eos_input_tp,
+    eos_input_rp,
+    eos_input_re,
+    eos_input_ps,
+    eos_input_ph,
+    eos_input_th};
 
 // these are used to allow for a generic interface to the
 // root finding
 
 namespace EOS {
 
-    enum eos_iter {itemp = 1,
-                   idens = 2,
-                   iener = 3,
-                   ienth = 4,
-                   ientr = 5,
-                   ipres = 6};
+    enum eos_iter : std::uint8_t {
+        itemp = 1,
+        idens = 2,
+        iener = 3,
+        ienth = 4,
+        ientr = 5,
+        ipres = 6};
 
 }
 

networks/aprox19/actual_network.H

@@ -157,7 +157,7 @@ namespace NSE_INDEX
 #endif
 
 namespace Rates {
-    enum NetworkRates {
+    enum NetworkRates : std::uint8_t {
         H1_H1_to_He3 = 1,
         H1_H1_H1_to_He3,
         P_to_N,

unit_test/burn_cell_sdc/burn_cell.H

@@ -45,7 +45,8 @@ void burn_cell_c()
         case 3:
             auxdata[n-1] = Aux3;
             break;
-
+        default:
+            amrex::Error("invalid aux");
         }
 
     }