Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Comment: Add Details of Commit Hash For all @git Refs #224

Open
CodeGat opened this issue Feb 10, 2025 · 0 comments
Open

Deployment Comment: Add Details of Commit Hash For all @git Refs #224

CodeGat opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
for:v4 Applies to `v4` priority:low type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories

Comments

@CodeGat
Copy link
Member

CodeGat commented Feb 10, 2025

Blocked by ACCESS-NRI/spack#4.

Background

Using @git.BRANCH refs means that when a package is built has an effect on the HEAD of the branch, and thus the built package. It's also quite hard to actually know which commit was used in a @git.BRANCH ref.

Implementation Plan

  • In the deployment comment, add another collapsable section that displays all commit references for packages with @git. refs.
    • Consider how to get the actual commit reference of a branch ref. I suspect we would need to interrogate the low level package details via spack python

Thanks @anton-seaice !

@CodeGat CodeGat added for:v4 Applies to `v4` priority:low type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories labels Feb 10, 2025
@CodeGat CodeGat self-assigned this Feb 10, 2025
@CodeGat CodeGat changed the title Deployment Comment: Add Details of Commit Hassh For all @git Ref Deployment Comment: Add Details of Commit Hash For all @git Refs Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for:v4 Applies to `v4` priority:low type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories
Projects
None yet
Development

No branches or pull requests

1 participant