Lint config changes (#3926)

* Lint config changes

Signed-off-by: Steve Coffman <[email protected]>

* Remove outdated nolint comments

Signed-off-by: Steve Coffman <[email protected]>

* Exclude generated resolvers from formatters

Signed-off-by: Steve Coffman <[email protected]>

* Further lint

Signed-off-by: Steve Coffman <[email protected]>

* More lints

Signed-off-by: Steve Coffman <[email protected]>

* Format

Signed-off-by: Steve Coffman <[email protected]>

* More Lint

Signed-off-by: Steve Coffman <[email protected]>

* Remove t.Helper()

* Minor tweak

Signed-off-by: Steve Coffman <[email protected]>

* Regenerate

Signed-off-by: Steve Coffman <[email protected]>

---------

Signed-off-by: Steve Coffman <[email protected]>

Author: StevenACoffman

.golangci.yml

@@ -1,13 +1,50 @@
+# All settings can be found here https://github.com/golangci/golangci-lint/blob/HEAD/.golangci.reference.yml
 version: "2"
 run:
+  concurrency: 8
+  modules-download-mode: readonly
+  issues-exit-code: 1
   tests: true
+  allow-parallel-runners: false
+issues:
+  # Maximum count of issues with the same text.
+  # Set to 0 to disable.
+  # Default: 3
+  max-issues-per-linter: 0
+  max-same-issues: 0
+  new: false
+formatters:
+  exclusions:
+    paths:
+        - codegen/testserver/followschema/resolver.go
+        - codegen/testserver/singlefile/resolver.go
+        - codegen/testserver/usefunctionsyntaxforexecutioncontext/resolver.go
+        - generated
+  enable:
+    - golines
+    - gofumpt
+    - gci
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - prefix(github.com/99designs/gqlgen)
+    golines:
+      # Target maximum line length.
+      # Default: 100
+      max-len: 100
 linters:
   default: none
   enable:
+    - asasalint
+    - asciicheck
+    - bidichk
     - bodyclose
     - copyloopvar
     - dupl
     - dupword
+    - durationcheck
     - errcheck
     - gocritic
     - govet
@@ -17,17 +54,28 @@ linters:
     - nolintlint
     - perfsprint
     - prealloc
+    - reassign
     - revive
     - staticcheck
+    - testableexamples
     - testifylint
     - unconvert
+    - unparam
     - unused
+    - usestdlibvars
+    - usetesting
+    - wastedassign
   settings:
     errcheck:
       exclude-functions:
         - (io.Writer).Write
+        - (http.ResponseWriter).Write
+        - (*bytes.Buffer).WriteByte
+        - (*strings.Builder).WriteByte
+        - (*strings.Builder).WriteString
         - io.Copy
         - io.WriteString
+        - fmt.Fprintln
     gocritic:
       enabled-checks:
         - emptyStringTest
@@ -136,17 +184,4 @@ linters:
       - third_party$
       - builtin$
       - examples$
-formatters:
-  enable:
-    - gofmt
-    - goimports
-  exclusions:
-    generated: lax
-    paths:
-      - bin
-      - third_party$
-      - builtin$
-      - examples$
-issues:
-  max-issues-per-linter: 0
-  max-same-issues: 0
+      - generated$

_examples/chat/chat_test.go

@@ -7,12 +7,12 @@ import (
 	"testing"
 	"time"
 
-	"github.com/99designs/gqlgen/graphql/handler/transport"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/99designs/gqlgen/client"
 	"github.com/99designs/gqlgen/graphql/handler"
+	"github.com/99designs/gqlgen/graphql/handler/transport"
 )
 
 func TestChatSubscriptions(t *testing.T) {
@@ -83,7 +83,8 @@ func TestChatSubscriptions(t *testing.T) {
 	}
 	wg.Wait()
 
-	// 1 for the main thread, 1 for the testing package and remainder is reserved for the HTTP server threads
+	// 1 for the main thread, 1 for the testing package and remainder is reserved for the HTTP
+	// server threads
 	// TODO: use something like runtime.Stack to filter out HTTP server threads,
 	// TODO: which is required for proper concurrency and leaks testing
 	require.Less(t, runtime.NumGoroutine(), 1+1+batchSize*2, "goroutine leak")

_examples/chat/resolvers.go

@@ -62,7 +62,10 @@ type Chatroom struct {
 
 type mutationResolver struct{ *resolver }
 
-func (r *mutationResolver) Post(ctx context.Context, text, username, roomName string) (*Message, error) {
+func (r *mutationResolver) Post(
+	ctx context.Context,
+	text, username, roomName string,
+) (*Message, error) {
 	room := r.getRoom(roomName)
 
 	message := &Message{
@@ -99,7 +102,10 @@ func (r *queryResolver) Room(ctx context.Context, name string) (*Chatroom, error
 
 type subscriptionResolver struct{ *resolver }
 
-func (r *subscriptionResolver) MessageAdded(ctx context.Context, roomName string) (<-chan *Message, error) {
+func (r *subscriptionResolver) MessageAdded(
+	ctx context.Context,
+	roomName string,
+) (<-chan *Message, error) {
 	room := r.getRoom(roomName)
 
 	id := randString(8)

_examples/config/schema.resolvers.go

@@ -27,8 +27,7 @@ func New() Config {
 	return c
 }
 
-type Resolver struct {
-}
+type Resolver struct{}
 
 func (r *Resolver) Query() QueryResolver {
 	return r

_examples/config/todo.resolvers.go

@@ -3,12 +3,12 @@ package dataloader
 import (
 	"testing"
 
-	"github.com/99designs/gqlgen/graphql/handler/extension"
-	"github.com/99designs/gqlgen/graphql/handler/transport"
 	"github.com/stretchr/testify/require"
 
 	"github.com/99designs/gqlgen/client"
 	"github.com/99designs/gqlgen/graphql/handler"
+	"github.com/99designs/gqlgen/graphql/handler/extension"
+	"github.com/99designs/gqlgen/graphql/handler/transport"
 	"github.com/99designs/gqlgen/graphql/introspection"
 )
 
@@ -50,7 +50,8 @@ func TestTodo(t *testing.T) {
 		}, resp.Torture2d)
 	})
 
-	// Input coercion on arrays should convert non array values into an array of the appropriate depth
+	// Input coercion on arrays should convert non array values into an array of the appropriate
+	// depth
 	// http://facebook.github.io/graphql/June2018/#sec-Type-System.List
 	t.Run("array coercion", func(t *testing.T) {
 		t.Run("1d", func(t *testing.T) {
@@ -88,6 +89,10 @@ func TestTodo(t *testing.T) {
 		}
 		err := c.Post(`{ torture2d(customerIds:{}) { id name } }`, &resp)
 
-		require.EqualError(t, err, "[{\"message\":\"map[string]interface {} is not an int\",\"path\":[\"torture2d\",\"customerIds\",0,0]}]")
+		require.EqualError(
+			t,
+			err,
+			"[{\"message\":\"map[string]interface {} is not an int\",\"path\":[\"torture2d\",\"customerIds\",0,0]}]",
+		)
 	})
 }

_examples/config/user.resolvers.go

@@ -48,7 +48,10 @@ func LoaderMiddleware(next http.Handler) http.Handler {
 				addresses := make([]*Address, len(keys))
 				errors := make([]error, len(keys))
 				for i, key := range keys {
-					addresses[i] = &Address{Street: "home street", Country: "hometon " + strconv.Itoa(key)}
+					addresses[i] = &Address{
+						Street:  "home street",
+						Country: "hometon " + strconv.Itoa(key),
+					}
 				}
 				return addresses, errors
 			},
@@ -64,16 +67,27 @@ func LoaderMiddleware(next http.Handler) http.Handler {
 					keySql = append(keySql, strconv.Itoa(key))
 				}
 
-				fmt.Printf("SELECT * FROM orders WHERE customer_id IN (%s)\n", strings.Join(keySql, ","))
+				fmt.Printf(
+					"SELECT * FROM orders WHERE customer_id IN (%s)\n",
+					strings.Join(keySql, ","),
+				)
 				time.Sleep(5 * time.Millisecond)
 
 				orders := make([][]*Order, len(keys))
 				errors := make([]error, len(keys))
 				for i, key := range keys {
 					id := 10 + rand.Int()%3
 					orders[i] = []*Order{
-						{ID: id, Amount: rand.Float64(), Date: time.Now().Add(-time.Duration(key) * time.Hour)},
-						{ID: id + 1, Amount: rand.Float64(), Date: time.Now().Add(-time.Duration(key) * time.Hour)},
+						{
+							ID:     id,
+							Amount: rand.Float64(),
+							Date:   time.Now().Add(-time.Duration(key) * time.Hour),
+						},
+						{
+							ID:     id + 1,
+							Amount: rand.Float64(),
+							Date:   time.Now().Add(-time.Duration(key) * time.Hour),
+						},
 					}
 
 					// if you had another customer loader you would prime its cache here
@@ -94,7 +108,10 @@ func LoaderMiddleware(next http.Handler) http.Handler {
 					keySql = append(keySql, strconv.Itoa(key))
 				}
 
-				fmt.Printf("SELECT * FROM items JOIN item_order WHERE item_order.order_id IN (%s)\n", strings.Join(keySql, ","))
+				fmt.Printf(
+					"SELECT * FROM items JOIN item_order WHERE item_order.order_id IN (%s)\n",
+					strings.Join(keySql, ","),
+				)
 				time.Sleep(5 * time.Millisecond)
 
 				items := make([][]*Item, len(keys))

_examples/contextpropagation/todo.go

@@ -85,7 +85,11 @@ func (r *queryResolver) Torture2d(ctx context.Context, customerIds [][]int) ([][
 	for i := range customerIds {
 		inner := make([]*Customer, len(customerIds[i]))
 		for j := range customerIds[i] {
-			inner[j] = &Customer{ID: customerIds[i][j], Name: fmt.Sprintf("%d %d", i, j), AddressID: rand.Int() % 10}
+			inner[j] = &Customer{
+				ID:        customerIds[i][j],
+				Name:      fmt.Sprintf("%d %d", i, j),
+				AddressID: rand.Int() % 10,
+			}
 		}
 		result[i] = inner
 	}