⭐ Implement State.fromValue #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical to the `State.fromAttribute` method, but for Roblox Values Instances.
4x8Matrix
reviewed
Mar 2, 2025
| ... | ||
| ``` | ||
| ]=] | ||
| function State.Interface.fromValue(object: Instance & { Value: any? }): State |
There was a problem hiding this comment.
Suggested change
| function State.Interface.fromValue(object: Instance & { Value: any? }): State | |
| function State.Interface.fromValue(object: ValueBase & { Value: any? }): State |
There was a problem hiding this comment.
I had it as ValueBase at first but opted for Instance instead as it adds nothing; none of the Value classes such as StringValue even inherit from the ValueBase class. It doesn't contain the one thing all of the Value classes share: a Value property - I don't even know why it exists. Moreover, everyone is familiar with Instance so I want to argue it's easier comprehension, even if nothing changes Intellisense-wise.
I have no problem conforming it but I thought I'd give my thoughts 🍀
| @function fromValue | ||
| @within State | ||
|
|
||
| @param object Instance & { Value: any? } |
There was a problem hiding this comment.
Suggested change
| @param object Instance & { Value: any? } | |
| @param object ValueBase & { Value: any? } |
4x8Matrix
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to the
State.fromAttributemethod, but for Roblox Values Instances.