Fix property value loss when renaming a property in the extension editor #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

D8H merged 2 commits into master from rename-property

Feb 5, 2026

Core/GDCore/IDE/Events/BehaviorPropertyRenamer.cpp

-Original file line number
+Diff line change
@@ -0,0 +1,21 @@
+    #include "BehaviorPropertyRenamer.h"
+    #include "GDCore/Events/Instruction.h"
+    #include "GDCore/Extensions/Metadata/MetadataProvider.h"
+    #include "GDCore/Extensions/PlatformExtension.h"
+    #include "GDCore/IDE/WholeProjectRefactorer.h"
+    #include "GDCore/Project/Behavior.h"
+    #include "GDCore/Project/Object.h"
+    #include "GDCore/Project/Project.h"
+    namespace gd {
+    void BehaviorPropertyRenamer::DoVisitBehavior(gd::Behavior &behavior) {
+      if (behavior.GetTypeName() == behaviorType) {
+        behavior.RenameProperty(oldName, newName);
+      }
+    };
+    BehaviorPropertyRenamer::~BehaviorPropertyRenamer() {}
+    } // namespace gd

Core/GDCore/IDE/Events/BehaviorPropertyRenamer.h

-Original file line number
+Diff line change
@@ -0,0 +1,39 @@
+    /*
+     * GDevelop Core
+     * Copyright 2008-2026 Florian Rival (Florian.Rival@gmail.com). All rights
+     * reserved. This project is released under the MIT License.
+     */
+    #pragma once
+    #include <set>
+    #include "GDCore/IDE/Project/ArbitraryObjectsWorker.h"
+    #include "GDCore/String.h"
+    namespace gd {
+    class Object;
+    class Behavior;
+    } // namespace gd
+    namespace gd {
+    /**
+     * \brief Rename a property in behaviors of all objects.
+     */
+    class GD_CORE_API BehaviorPropertyRenamer : public ArbitraryObjectsWorker {
+    public:
+      BehaviorPropertyRenamer(const gd::String &behaviorType_,
+                              const gd::String &oldName_,
+                              const gd::String &newName_)
+          : behaviorType(behaviorType_), oldName(oldName_), newName(newName_){};
+      virtual ~BehaviorPropertyRenamer();
+    private:
+      void DoVisitBehavior(gd::Behavior &behavior) override;
+      gd::String behaviorType;
+      gd::String oldName;
+      gd::String newName;
+    };
+    }; // namespace gd

Core/GDCore/IDE/Events/BehaviorTypeRenamer.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,8 +4,7 @@ @@
      * reserved. This project is released under the MIT License.
      */
-    #ifndef GDCORE_BEHAVIORTYPERENAMER_H
-    #define GDCORE_BEHAVIORTYPERENAMER_H
+    #pragma once
     #include <set>
     #include "GDCore/IDE/Project/ArbitraryObjectsWorker.h"
@@ Expand Down Expand Up @@
     };
     };  // namespace gd
-    #endif // GDCORE_BEHAVIORTYPERENAMER_H

Core/GDCore/IDE/Events/ObjectPropertyRenamer.cpp

-Original file line number
+Diff line change
@@ -0,0 +1,21 @@
+    #include "ObjectPropertyRenamer.h"
+    #include "GDCore/Events/Instruction.h"
+    #include "GDCore/Extensions/Metadata/MetadataProvider.h"
+    #include "GDCore/Extensions/PlatformExtension.h"
+    #include "GDCore/IDE/WholeProjectRefactorer.h"
+    #include "GDCore/Project/Behavior.h"
+    #include "GDCore/Project/Object.h"
+    #include "GDCore/Project/Project.h"
+    namespace gd {
+    void ObjectPropertyRenamer::DoVisitObject(gd::Object &object) {
+      if (object.GetType() == objectType) {
+        object.GetConfiguration().RenameProperty(oldName, newName);
+      }
+    };
+    ObjectPropertyRenamer::~ObjectPropertyRenamer() {}
+    } // namespace gd

Core/GDCore/IDE/Events/ObjectPropertyRenamer.h

-Original file line number
+Diff line change
@@ -0,0 +1,38 @@
+    /*
+     * GDevelop Core
+     * Copyright 2008-2026 Florian Rival (Florian.Rival@gmail.com). All rights
+     * reserved. This project is released under the MIT License.
+     */
+    #pragma once
+    #include <set>
+    #include "GDCore/IDE/Project/ArbitraryObjectsWorker.h"
+    #include "GDCore/String.h"
+    namespace gd {
+    class Object;
+    class Behavior;
+    } // namespace gd
+    namespace gd {
+    /**
+     * \brief Rename a property in all custom objects of a given type.
+     */
+    class GD_CORE_API ObjectPropertyRenamer : public ArbitraryObjectsWorker {
+    public:
+      ObjectPropertyRenamer(const gd::String &objectType_,
+                            const gd::String &oldName_, const gd::String &newName_)
+          : objectType(objectType_), oldName(oldName_), newName(newName_){};
+      virtual ~ObjectPropertyRenamer();
+    private:
+      void DoVisitObject(gd::Object &object) override;
+      gd::String objectType;
+      gd::String oldName;
+      gd::String newName;
+    };
+    }; // namespace gd

Core/GDCore/IDE/WholeProjectRefactorer.cpp

-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,7 @@ @@
     #include "GDCore/IDE/EventBasedObjectBrowser.h"
     #include "GDCore/IDE/Events/ArbitraryEventsWorker.h"
     #include "GDCore/IDE/Events/BehaviorParametersFiller.h"
+    #include "GDCore/IDE/Events/BehaviorPropertyRenamer.h"
     #include "GDCore/IDE/Events/BehaviorTypeRenamer.h"
     #include "GDCore/IDE/Events/CustomObjectTypeRenamer.h"
     #include "GDCore/IDE/Events/EventsBehaviorRenamer.h"
@@ Expand All / @@ -30,6 +31,7 @@ @@
     #include "GDCore/IDE/Events/InstructionsTypeRenamer.h"
     #include "GDCore/IDE/Events/LinkEventTargetRenamer.h"
     #include "GDCore/IDE/Events/LeaderboardIdRenamer.h"
+    #include "GDCore/IDE/Events/ObjectPropertyRenamer.h"
     #include "GDCore/IDE/Events/ProjectElementRenamer.h"
     #include "GDCore/IDE/Project/BehaviorObjectTypeRenamer.h"
     #include "GDCore/IDE/Project/BehaviorsSharedDataBehaviorTypeRenamer.h"
@@ Expand Down Expand Up @@
       auto &properties = eventsBasedBehavior.GetPropertyDescriptors();
       if (!properties.Has(oldPropertyName))
         return;
+      const auto &behaviorType = gd::PlatformExtension::GetBehaviorFullType(
+          eventsFunctionsExtension.GetName(), eventsBasedBehavior.GetName());
+      // Rename the property in behaviors of all objects.
+      const WholeProjectBrowser projectBrowser;
+      auto behaviorPropertyRenamer = gd::BehaviorPropertyRenamer(
+          behaviorType, oldPropertyName, newPropertyName);
+      projectBrowser.ExposeObjects(project, behaviorPropertyRenamer);
       if (properties.Get(oldPropertyName).GetType() == "Behavior") {
         // This is a property representing another behavior that must exist on the
@@ Expand Down Expand Up @@
         gd::ExpressionsRenamer expressionRenamer =
             gd::ExpressionsRenamer(project.GetCurrentPlatform());
         expressionRenamer.SetReplacedBehaviorExpression(
-            gd::PlatformExtension::GetBehaviorFullType(
-                eventsFunctionsExtension.GetName(), eventsBasedBehavior.GetName()),
+            behaviorType,
             EventsBasedBehavior::GetPropertyExpressionName(oldPropertyName),
             EventsBasedBehavior::GetPropertyExpressionName(newPropertyName));
         gd::ProjectBrowserHelper::ExposeProjectEvents(project, expressionRenamer);
@@ Expand Down Expand Up @@
       auto &properties = eventsBasedObject.GetPropertyDescriptors();
       if (!properties.Has(oldPropertyName))
         return;
+      const auto &objectType = gd::PlatformExtension::GetObjectFullType(
+          eventsFunctionsExtension.GetName(), eventsBasedObject.GetName());
+      // Rename the property in all custom objects of this type.
+      const WholeProjectBrowser projectBrowser;
+      auto objectPropertyRenamer =
+          gd::ObjectPropertyRenamer(objectType, oldPropertyName, newPropertyName);
+      projectBrowser.ExposeObjects(project, objectPropertyRenamer);
       // Properties that represent primitive values will be used through
       // their related actions/conditions/expressions. Rename these.
@@ Expand All @@
       gd::ExpressionsRenamer expressionRenamer =
           gd::ExpressionsRenamer(project.GetCurrentPlatform());
       expressionRenamer.SetReplacedObjectExpression(
-          gd::PlatformExtension::GetObjectFullType(
-              eventsFunctionsExtension.GetName(), eventsBasedObject.GetName()),
+          objectType,
           EventsBasedObject::GetPropertyExpressionName(oldPropertyName),
           EventsBasedObject::GetPropertyExpressionName(newPropertyName));
       gd::ProjectBrowserHelper::ExposeProjectEvents(project, expressionRenamer);
@@ Expand Down @@

Core/GDCore/Project/BehaviorConfigurationContainer.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -87,6 +87,17 @@ class GD_CORE_API BehaviorConfigurationContainer { @@
         return UpdateProperty(content, name, value);
       };
+      /**
+       * \brief Called when the IDE wants to rename a custom property of the object
+       * configuration.
+       *
+       * \return false if properties can't be renamed
+       */
+      virtual bool RenameProperty(const gd::String &oldName,
+                                  const gd::String &newName) {
+        return RenameProperty(content, oldName, newName);
+      };
       /**
        * \brief Called to initialize the content with the default properties
        * for the behavior.
@@ Expand Down Expand Up / @@ -199,6 +210,18 @@ class GD_CORE_API BehaviorConfigurationContainer { @@
         return false;
       };
+      /**
+       * \brief Called when the IDE wants to rename a custom property of the object
+       * configuration.
+       *
+       * \return false if properties can't be renamed
+       */
+      virtual bool RenameProperty(gd::SerializerElement &behaviorContent,
+                                  const gd::String &oldName,
+                                  const gd::String &newName) {
+        return false;
+      };
       /**
        * \brief Called to initialize the content with the default properties
        * for the behavior.
@@ Expand Down @@

Core/GDCore/Project/CustomBehavior.cpp

-Original file line number
+Diff line change
@@ Expand Up @@
           propertyName,
           newValue);
     }
+    bool CustomBehavior::RenameProperty(gd::SerializerElement &behaviorContent,
+                                        const gd::String &oldName,
+                                        const gd::String &newName) {
+      if (!project.HasEventsBasedBehavior(GetTypeName())) {
+        return false;
+      }
+      const auto &eventsBasedBehavior =
+          project.GetEventsBasedBehavior(GetTypeName());
+      const auto &properties = eventsBasedBehavior.GetPropertyDescriptors();
+      return gd::CustomConfigurationHelper::RenameProperty(
+          properties, behaviorContent, oldName, newName);
+    }

Core/GDCore/Project/CustomBehavior.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -37,6 +37,9 @@ class CustomBehavior : public gd::Behavior { @@
       bool UpdateProperty(gd::SerializerElement &behaviorContent,
                           const gd::String &name, const gd::String &value) override;
       void InitializeContent(gd::SerializerElement &behaviorContent) override;
+      bool RenameProperty(gd::SerializerElement &behaviorContent,
+                                  const gd::String &oldName,
+                                  const gd::String &newName) override;
     private:
       const Project &project; ///< The project is used to get the
@@ Expand Down @@

Core/GDCore/Project/CustomConfigurationHelper.cpp

-Original file line number
+Diff line change
@@ Expand Up / @@ -102,5 +102,19 @@ bool CustomConfigurationHelper::UpdateProperty( @@
         element.SetBoolValue(newValue == "1");
       }
+      return true;
+    }
+    bool CustomConfigurationHelper::RenameProperty(
+        const gd::PropertiesContainer &properties,
+        gd::SerializerElement &configurationContent, const gd::String &oldName,
+        const gd::String &newName) {
+      if (!configurationContent.HasChild(oldName)) {
+        return false;
+      }
+      auto &oldElement = configurationContent.GetChild(oldName);
+      auto &newElement = configurationContent.AddChild(newName);
+      newElement = oldElement;
+      configurationContent.RemoveChild(oldName);
       return true;
     }

Core/GDCore/Project/CustomConfigurationHelper.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -3,8 +3,7 @@ @@
      * Copyright 2008-2016 Florian Rival (Florian.Rival@gmail.com). All rights
      * reserved. This project is released under the MIT License.
      */
-    #ifndef GDCORE_CUSTOMCONFIGURATIONHELPER_H
-    #define GDCORE_CUSTOMCONFIGURATIONHELPER_H
+    #pragma once
     #include "GDCore/Project/Behavior.h"
     #include "GDCore/Project/EventsBasedBehavior.h"
@@ Expand Down Expand Up / @@ -38,7 +37,10 @@ class CustomConfigurationHelper { @@
           gd::SerializerElement &behaviorContent,
           const gd::String &name,
           const gd::String &value);
+      static bool RenameProperty(const gd::PropertiesContainer &properties,
+                                 gd::SerializerElement &behaviorContent,
+                                 const gd::String &oldName,
+                                 const gd::String &newName);
     };
     }  // namespace gd
-    #endif  // GDCORE_CUSTOMCONFIGURATIONHELPER_H

Core/GDCore/Project/CustomObjectConfiguration.cpp

-Original file line number
+Diff line change
@@ Expand Up @@
             newValue);
     }
+    bool CustomObjectConfiguration::RenameProperty(const gd::String& oldName, const gd::String& newName) {
+        if (!project->HasEventsBasedObject(GetType())) {
+          return false;
+        }
+        const auto &eventsBasedObject = project->GetEventsBasedObject(GetType());
+        const auto &properties = eventsBasedObject.GetPropertyDescriptors();
+        return gd::CustomConfigurationHelper::RenameProperty(
+            properties,
+            objectContent,
+            oldName,
+            newName);
+    };
     std::map<gd::String, gd::PropertyDescriptor>
     CustomObjectConfiguration::GetInitialInstanceProperties(
         const gd::InitialInstance &initialInstance) {
@@ Expand Down @@

Core/GDCore/Project/CustomObjectConfiguration.h

-Original file line number
+Diff line change
@@ Expand Up @@
       std::map<gd::String, gd::PropertyDescriptor> GetProperties() const override;
       bool UpdateProperty(const gd::String& name, const gd::String& value) override;
+      bool RenameProperty(const gd::String& oldName, const gd::String& newName) override;
       std::map<gd::String, gd::PropertyDescriptor> GetInitialInstanceProperties(
           const gd::InitialInstance& instance) override;
@@ Expand All @@
       void ExposeResources(gd::ArbitraryResourceWorker& worker) override;
       /**
        * \brief Get the name of the events-based object variant used by this custom object.
        */
@@ Expand Down @@

Core/GDCore/Project/ObjectConfiguration.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -99,6 +99,17 @@ class GD_CORE_API ObjectConfiguration { @@
       virtual bool UpdateProperty(const gd::String& name, const gd::String& value) {
         return false;
       };
+      /**
+       * \brief Called when the IDE wants to rename a custom property of the object
+       * configuration.
+       *
+       * \return false if properties can't be renamed
+       */
+      virtual bool RenameProperty(const gd::String &oldName,
+                                  const gd::String &newName) {
+        return false;
+      };
       ///@}
       /** \name Drawing and editing initial instances
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix property value loss when renaming a property in the extension editor #8211

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!