upgrade bondage to the yarn 2 spec - closes 6451 #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blurymind
changed the title
|
guess if you run Gdevelop with the dialogue tree project - with this branch you will see the stack and it is not helpful at all. It appears to get an exception at the second screenshot i made |
|
I just noticed the developer who upgraded this in a PR has a branch that is slightly ahead from the pr he made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new bondagejs appears to be imported correctly (see logging)
When trying to run my old test demo game however I get this error
@4ian @Silver-Streak any idea why this is happening? Is it something to do with how the umd module is configured?
This was one of the major things that the contributor did to modernize it. He migrated it from rollup/gulp to webpack
https://github.com/hylyh/bondage.js/blob/master/gulpfile.js
https://github.com/hylyh/bondage.js/blob/2.0/webpack.config.js
trying to address #6451
closes 6451 if I can ever figure out why the import no longer works in gdevelop