Skip to content

Commit a93dfb4

Browse files
fix: align testing code with now finished ruby/net-smtp gem
1 parent bf003aa commit a93dfb4

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ end
1515
group :testing do
1616
gem 'openssl'
1717
gem 'minitest'
18-
gem 'net-smtp', github: 'TomFreudenberg/net-smtp', branch: 'master'
18+
gem 'net-smtp', github: 'ruby/net-smtp', branch: 'master'
1919
gem 'mail'
2020
end

test/construct/base_integration_test_class.rb

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def net_smtp_send_mail(envelope_mail_from, envelope_rcpt_to, message_data, authe
3434
@smtpd.ssl_context.extra_chain_cert&.each { |c| store.add_cert(c) }
3535
end
3636

37-
if Net::SMTP.const_defined?('VERSION') && (Net::SMTP::VERSION > '0.2.1')
37+
if Net::SMTP.const_defined?('VERSION') && (Net::SMTP::VERSION >= '0.2.1')
3838
smtp.start('Integration Test client', authentication_id, password, auth_type, ssl_context_params: { cert_store: store, verify_mode: OpenSSL::SSL::VERIFY_PEER }) do
3939
# when sending mails, send one additional crlf to safe the original linebreaks
4040
smtp.send_message("#{message_data}\r\n", envelope_mail_from, envelope_rcpt_to)
@@ -51,7 +51,10 @@ def mikel_mail_send_mail(_envelope_mail_from, _envelope_rcpt_to, message_data, a
5151
m = Mail.read_from_string("#{message_data}\r\n")
5252

5353
store = OpenSSL::X509::Store.new
54-
store.add_cert(@smtpd.ssl_context.cert) if @smtpd.ssl_context
54+
if @smtpd.ssl_context
55+
store.add_cert(@smtpd.ssl_context.cert)
56+
@smtpd.ssl_context.extra_chain_cert&.each { |c| store.add_cert(c) }
57+
end
5558

5659
m.delivery_method \
5760
:smtp,

test/construct/mail_smtp_class_patch.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module Mail
1111
class SMTP
1212

1313
def start_smtp_session(&block)
14-
if Net::SMTP.const_defined?('VERSION') && (Net::SMTP::VERSION > '0.2.1')
14+
if Net::SMTP.const_defined?('VERSION') && (Net::SMTP::VERSION >= '0.2.1')
1515
build_smtp_session.start(settings[:domain], settings[:user_name], settings[:password], settings[:authentication], ssl_context_params: settings[:ssl_context_params], &block)
1616
else
1717
build_smtp_session.start(settings[:domain], settings[:user_name], settings[:password], settings[:authentication], &block)

0 commit comments

Comments
 (0)