lint: fix the address of a variable cannot be nil

Author: tkan145

pkg/3scale/amp/component/apicast_options.go

@@ -41,7 +41,7 @@ type APIcastTracingConfig struct {
 
 type OpentelemetryConfig struct {
 	Enabled    bool
-	Secret     v1.Secret
+	Secret     *v1.Secret
 	ConfigFile string
 }
 

pkg/3scale/amp/component/deployment_annotations.go

@@ -102,8 +102,8 @@ func getWatchedSecretAnnotations(ctx context.Context, client k8sclient.Client, d
 				}
 			}
 
-			if &apicast.Options.ProductionOpentelemetry != nil && apicast.Options.ProductionOpentelemetry.Enabled {
-				if &apicast.Options.ProductionOpentelemetry.Secret != nil && apicast.Options.ProductionOpentelemetry.Secret.Name != "" {
+			if apicast.Options.ProductionOpentelemetry.Enabled {
+				if apicast.Options.ProductionOpentelemetry.Secret != nil && apicast.Options.ProductionOpentelemetry.Secret.Name != "" {
 					telemetryConfigSecret := &corev1.Secret{}
 					telemetryConfigSecretKey := k8sclient.ObjectKey{
 						Name:      apicast.Options.ProductionOpentelemetry.Secret.Name,
@@ -154,8 +154,8 @@ func getWatchedSecretAnnotations(ctx context.Context, client k8sclient.Client, d
 				}
 			}
 
-			if &apicast.Options.StagingOpentelemetry != nil && apicast.Options.StagingOpentelemetry.Enabled {
-				if &apicast.Options.StagingOpentelemetry.Secret != nil && apicast.Options.StagingOpentelemetry.Secret.Name != "" {
+			if apicast.Options.StagingOpentelemetry.Enabled {
+				if apicast.Options.StagingOpentelemetry.Secret != nil && apicast.Options.StagingOpentelemetry.Secret.Name != "" {
 					telemetryConfigSecret := &corev1.Secret{}
 					telemetryConfigSecretKey := k8sclient.ObjectKey{
 						Name:      apicast.Options.StagingOpentelemetry.Secret.Name,

pkg/3scale/amp/operator/apicast_options_provider.go

@@ -539,7 +539,7 @@ func (a *ApicastOptionsProvider) getOpenTelemetryStagingConfig(ctx context.Conte
 		return res, err.ToAggregate()
 	}
 
-	res.Secret = *secret
+	res.Secret = secret
 
 	secretKeys := helper.MapKeys(helper.GetSecretStringDataFromData(secret.Data))
 	if len(secretKeys) == 0 {
@@ -602,7 +602,7 @@ func (a *ApicastOptionsProvider) getOpenTelemetryProductionConfig(ctx context.Co
 		return res, err.ToAggregate()
 	}
 
-	res.Secret = *secret
+	res.Secret = secret
 
 	secretKeys := helper.MapKeys(helper.GetSecretStringDataFromData(secret.Data))
 	if len(secretKeys) == 0 {

pkg/3scale/amp/operator/apicast_options_provider_test.go

@@ -332,7 +332,7 @@ func TestGetApicastOptionsProvider(t *testing.T) {
 				opentelemtryKey := component.OpentelemetryConfigMountBasePath + "/some-key"
 
 				opts.StagingOpentelemetry.Enabled = trueOpenTelemetry
-				opts.StagingOpentelemetry.Secret = *otlpSecret()
+				opts.StagingOpentelemetry.Secret = otlpSecret()
 				opts.StagingOpentelemetry.ConfigFile = opentelemtryKey
 
 				return opts
@@ -359,7 +359,7 @@ func TestGetApicastOptionsProvider(t *testing.T) {
 				opentelemtryKey := component.OpentelemetryConfigMountBasePath + "/config.json"
 
 				opts.ProductionOpentelemetry.Enabled = trueOpenTelemetry
-				opts.ProductionOpentelemetry.Secret = *otlpSecret()
+				opts.ProductionOpentelemetry.Secret = otlpSecret()
 				opts.ProductionOpentelemetry.ConfigFile = opentelemtryKey
 
 				return opts