Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release_3_8] [Bugfix] Edition : exec a DELETE can return 0 in some cases #5109

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

3liz-bot
Copy link
Contributor

Backport #5093
Authored by: @rldhont

`jDbConnection::exec()` returns the number of affected rows or False if the query has failed.

In some cases, for exemple a DELETE on a view or a DELETE catches by a trigger can return no affected rows.
So lizmap has to rollback() executed requests only if a query has failed.

Funded by Conseil Départemental du Calvados and Ville d'Avignon
@github-actions github-actions bot added this to the 3.8.4 milestone Dec 11, 2024
@github-actions github-actions bot added sponsored development This development has been funded run end2end If the PR must run end2end tests or not data editor labels Dec 11, 2024
Copy link

Conseil Départemental du Calvados and Ville d'Avignon

@rldhont rldhont added run end2end If the PR must run end2end tests or not and removed run end2end If the PR must run end2end tests or not labels Dec 11, 2024
@rldhont rldhont merged commit 2788e87 into release_3_8 Dec 11, 2024
14 checks passed
@rldhont rldhont deleted the backport-5093-to-release_3_8 branch December 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data editor run end2end If the PR must run end2end tests or not sponsored development This development has been funded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants