fix: rewrite QGIS BS4 tab attributes to BS5 before inserting popup HTML

QGIS Server generates data-toggle="tab" (Bootstrap 4 syntax). Bootstrap 5's
data-API only responds to data-bs-toggle="tab", so tabs were never activated.
Replace the attribute in the HTML string before DOM insertion; Bootstrap 5 then
handles tab switching natively, and the manual event-listener workaround is no
longer needed.

Author: meyerlor

assets/src/legacy/map.js

@@ -844,6 +844,10 @@ window.lizMap = function() {
 
         var eventLonLatInfo = map.getLonLatFromPixel(xy);
 
+        // QGIS Server generates Bootstrap 4 data-toggle="tab"; rewrite to Bootstrap 5 syntax
+        // so the native data-API handles tab switching without custom event listeners.
+        text = text.replace(/data-toggle="tab"/g, 'data-bs-toggle="tab"');
+
         var popup = null;
         var popupContainerId = null;
         if( 'popupLocation' in config.options && config.options.popupLocation != 'map' ){
@@ -900,28 +904,9 @@ window.lizMap = function() {
                 lizMap.mainLizmap.popup.mapPopup.setPosition([eventLonLatInfo.lon, eventLonLatInfo.lat]);
             }
 
-            document.getElementById('liz_layer_popup_contentDiv')
-                .querySelectorAll('a[data-toggle="tab"]')
-                .forEach(el => {
-                    el.addEventListener('click', e => {
-                        e.preventDefault();
-                        bootstrap.Tab.getOrCreateInstance(el).show();
-                    });
-                });
         }
         lastLonLatInfo = eventLonLatInfo;
 
-        // Activate tabs in dock popup (popupcontent)
-        if (popupContainerId) {
-            document.querySelectorAll('#' + popupContainerId + ' a[data-toggle="tab"]')
-                .forEach(el => {
-                    el.addEventListener('click', e => {
-                        e.preventDefault();
-                        bootstrap.Tab.getOrCreateInstance(el).show();
-                    });
-                });
-        }
-
         // Display related children objects
         addChildrenFeatureInfo( popup, popupContainerId );
         // Display geometries