LiarGame Subject Select View & LiarGame View early Setup #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elppaaa
requested changes
Apr 25, 2022
LiarGame/Sources/ViewController/LiarGame/LiarGameSubjectViewController.swift
Outdated
Show resolved
Hide resolved
LiarGame/Sources/ViewController/LiarGame/LiarGameSubjectViewController.swift
Outdated
Show resolved
Hide resolved
LiarGame/Sources/ViewController/LiarGame/LiarGameSubjectViewController.swift
Outdated
Show resolved
Hide resolved
LiarGame/Sources/ViewController/LiarGame/LiarGameSubjectViewController.swift
Outdated
Show resolved
Hide resolved
LiarGame/Sources/ViewController/LiarGame/LiarGameSubjectViewController.swift
Outdated
Show resolved
Hide resolved
…lex Container addsubview 제거
|
리뷰해주신 부분 참고해서 수정 완료했습니다. 확인 후 merge 부탁드려요! |
elppaaa
approved these changes
Apr 26, 2022
Merged
elppaaa
reviewed
Apr 26, 2022
|
|
||
| func setupView(){ | ||
| animalButton.do{ | ||
| self.view.addSubview($0) |
There was a problem hiding this comment.
view.addSubview 가 아직 존재합니다 (˃̣̣̣̣︿˂̣̣̣̣ )
view hierarchy 를 보면 flexLayoutContainer 에서 addItem 이 호출될때
추가된걸 확인할 수 있습니다 :]
신기하게 충돌은 안나네요 🦀
There was a problem hiding this comment.
네 확인했습니다.
self.view.addSubview($0)
self.view.addSubview($0)
self.view.addSubview($0)
같은 요소 여러개 추가하는걸로 제가 테스트 해봤는데 동일 인스턴스는 아무리 추가해도 하나밖에 안되도록 애플에서 그렇게 만들었나보네요
수정 완료했습니다!
| .distinctUntilChanged() | ||
| .withUnretained(self) | ||
| .subscribe(onNext:{ `self`, subject in | ||
| let liarGameVC = LiarGameViewController(subject: subject ?? .job) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배경
라이어 게임 주제 선택 이후 라이어 게임까지 갈 수 있는 화면을 초기 구성이 필요하였습니다.
목적
LiarGame Subject Select View & LiarGame View early Setup
리뷰 시 참고사항