From f17c600b47e64b42e693a35cfd1c2b5e951ede68 Mon Sep 17 00:00:00 2001 From: Georgiana Dolocan Date: Sat, 25 May 2024 18:10:39 +0300 Subject: [PATCH] Export JUPYTERHUB_BASE_URL instead of JUPYTHUB_API_URL to fix redirect --- config/clusters/2i2c/binderhub-ui-demo.values.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/config/clusters/2i2c/binderhub-ui-demo.values.yaml b/config/clusters/2i2c/binderhub-ui-demo.values.yaml index fce3ff1c69..8796e105fd 100644 --- a/config/clusters/2i2c/binderhub-ui-demo.values.yaml +++ b/config/clusters/2i2c/binderhub-ui-demo.values.yaml @@ -41,7 +41,7 @@ jupyterhub: binder: # FIXME: ref https://github.com/2i2c-org/binderhub-service/issues/57 # for something more readable and requiring less copy-pasting - display: true + display: false oauth_no_confirm: true url: http://binderhub-ui-demo-binderhub-service:8090 oauth_redirect_uri: https://binderhub-ui-demo.2i2c.cloud/oauth_callback @@ -61,7 +61,6 @@ jupyterhub: http://google.com/accounts/o8/id: username_derivation: username_claim: "email" - binderhub-service: enabled: true ingress: @@ -84,11 +83,13 @@ binderhub-service: key: hub.services.binder.apiToken - name: JUPYTERHUB_CLIENT_ID value: "service-binder" + # Without this, the redirect URL to /hub/api/... gets + # appended to binderhub's URL instead of the hub's + # and setting JUPYTHUB_API_URL has no effect + - name: JUPYTERHUB_BASE_URL + value: "https://hub.binderhub-ui-demo.2i2c.cloud/" - name: JUPYTERHUB_OAUTH_CALLBACK_URL value: "https://binderhub-ui-demo.2i2c.cloud/oauth_callback" - - name: JUPYTERHUB_API_URL - value: "https://hub.binderhub-ui-demo.2i2c.cloud/hub/api" - config: BinderHub: base_url: /