Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default low_threshold and high_threshold #140

Closed
maurolepore opened this issue Mar 12, 2024 · 0 comments · Fixed by #141
Closed

Use default low_threshold and high_threshold #140

maurolepore opened this issue Mar 12, 2024 · 0 comments · Fixed by #141
Assignees

Comments

@maurolepore
Copy link
Contributor

maurolepore commented Mar 12, 2024

While thresholds remain unparametrized (#23) it's safest to use the defaults.

Currently the workflows profile_sector*.Rmd use the wrong *threshold, and it also makes this package harder to maintain -- because when the default *threshold change upstream (e.g. in tiltIndicator) we need to remember to update the values used in each workflow. It's best to remove the *threshold and let each profile*() use the defaults.

Here's the biggest problem, compare:

Good: Helpfile

image

Bad: Workflow

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant