Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output files from Sven the same as from Mauro? #111

Open
AnneSchoenauer opened this issue Jan 4, 2024 · 3 comments
Open

Output files from Sven the same as from Mauro? #111

AnneSchoenauer opened this issue Jan 4, 2024 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@AnneSchoenauer
Copy link

@Tilmon and I reviewed the output table from Sven which can be found here. We discussed before Christmas that it would be great if you @SKruthoff check if your output tables are the same as Mauro's output tables.

I think one different for sure will be that I never heard about row_id in our output files. Most likely something that came out when doing the process with Databricks? Anyways, curious to see what comes out of the analysis.

Best
Anne

@AnneSchoenauer AnneSchoenauer transferred this issue from 2DegreesInvesting/tiltIndicator Jan 4, 2024
@AnneSchoenauer AnneSchoenauer added the question Further information is requested label Jan 4, 2024
@Tilmon
Copy link
Collaborator

Tilmon commented Jan 16, 2024

Hey @SKruthoff would be great if you could give us an update here. Thanks!
cc' @AnneSchoenauer

@SKruthoff
Copy link
Collaborator

Hi,

I have started on the checks. So far there seems to be a lot of overlap between the two. I will compile a more detailed overview over the next couple of days.

The part where there is a bigger discrepancy is the upstream profiles. Kalash right now is working on removing a column that seems to be the cause of the duplication that should address this issue. Further than that I have found that there are some differences in the matching company average between the results of Mauro and me.

@Tilmon
Copy link
Collaborator

Tilmon commented Jan 17, 2024

Thanks for the update! Looking forward to the overview!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants