Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Extract more code into preparation functions #126

Open
lindadelacombaz opened this issue Mar 19, 2024 · 1 comment
Open

Refactoring: Extract more code into preparation functions #126

lindadelacombaz opened this issue Mar 19, 2024 · 1 comment
Assignees
@lindadelacombaz
Labels
enhancement New feature or request

Comments

@lindadelacombaz
Copy link
Collaborator

lindadelacombaz commented Mar 19, 2024 •
edited
Loading

I feel like it is the time that my package need to be more consistent and clear within its code.

  • Consistency with naming variables.
  • Add helper functions so my functions would in the end look like this (c.f. mauro's comment).
  • Change the tests such that it will be "humble objects", c.f. discussion here
  • Integrate the changes discussed with Anne.
@lindadelacombaz lindadelacombaz self-assigned this Mar 19, 2024
@lindadelacombaz lindadelacombaz changed the title Refactor tiltPlot package Refactoring: Consistency with naming variables & more concise functions Mar 19, 2024
@lindadelacombaz lindadelacombaz changed the title Refactoring: Consistency with naming variables & more concise functions Refactoring: Extract more code into preparation functions Mar 19, 2024
@lindadelacombaz lindadelacombaz added the enhancement New feature or request label Mar 19, 2024
@maurolepore
Copy link
Contributor

@lindadelacombaz it seems you meant to open this PR in tiltPlot. I'll move it there.

@maurolepore maurolepore pinned this issue May 8, 2024
@maurolepore maurolepore transferred this issue from 2DegreesInvesting/tiltIndicator May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindadelacombaz lindadelacombaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maurolepore @lindadelacombaz