-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profile_sector()
fails to handle case "c"
#279
Comments
sector_profile()
sector_profile()
on product-level
@maurolepore addendum: The dataset |
sector_profile()
on product-levelgrouped_by
weo_x are not preserved for sector_profile()
on product-level
@Tilmon the problem seems to be in tiltIndicatorAfter. I'll transfer this issue from tiltIndicator to tiltIndicatorAfter. |
grouped_by
weo_x are not preserved for sector_profile()
on product-levelprofile_sector()
should include a scenario
of unmatched type
profile_sector()
should include a scenario
of unmatched type
profile_sector()
fails to handle the case "c"
profile_sector()
fails to handle the case "c"profile_sector()
fails to handle case "c"
clustered
is "c" in the reprex we used to check this issue was fixed:sector_profile()
now accounts for unmatchedtype
,sector
orsubsector
tiltIndicator#739The following expectation is met for
tiltIndicator::sector_profile()
but not fortiltIndicatorAfter::profile_sector()
(reprex):scenarios
dataset also includes data from "weo",scenario
comes from "weo" andsector_profile
isNA
.(Original)
Dear @maurolepore,
in the output you created for Bundesbank, I realized that NAs are not preserved for
sector_profile()
on product-level as they should, acc. to this reprex.Specifically, I'm referring to cases similar to the
clustered
"c" in the reprex - a product in the Land Use sector which hence only has results for IPR scenarios, not for WEO scenarios. Acc. to the reprex, this should lead on product-level to therisk_category
== NA forgrouped_by
== WEO (see screenshot below)However, this is not how the data behave in the output you shared: I identified a company that only has products in land use sector. While on company-level, the NAs for WEO are shown, on product-level, the output only shows the IPR scenario.
Please bare with me... I wanted to share a reprex... But I get errors. I will try to solve the erros, but given the end is coming to an end, I'll just copy in my code here.
The input data I load are from the latest Release v0.0.0.9003. The code just shows the output for the sample company. You'll see that the
grouped_by
== WEO is missing on product-level.`
cc' @AnneSchoenauer @kalashsinghal
The text was updated successfully, but these errors were encountered: