Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ei_geography and input_ei_geography columns to product level outputs of all four profile indicators #148

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Add ei_geography and input_ei_geography columns to product level outputs of all four profile indicators #148

merged 1 commit into from
Jan 30, 2024

Conversation

kalashsinghal
Copy link
Collaborator

@kalashsinghal kalashsinghal commented Jan 29, 2024 •
edited
Loading

closes #119

This PR adds ei_geography column in emission_profile and sector_profile at product level, and adds both ei_geography and ei_input_geography in emission_profile_upstream and sector_profile_upstream at product level.

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@kalashsinghal kalashsinghal merged commit 9cb0eab into main Jan 30, 2024
6 of 7 checks passed
@kalashsinghal kalashsinghal deleted the 119_add_GEO_column branch January 30, 2024 09:20
@kalashsinghal kalashsinghal mentioned this pull request Jan 30, 2024
Closed
@kalashsinghal
Copy link
Collaborator Author

@maurolepore All the checks passed in this PRhttps://github.com/2DegreesInvesting/tiltWorkflows/pull/120, however in this current PR one dependency check on tiltToyData failed. All the tests locally passed while checking with devtools::check() in tiltIndicatorAfter as well. Do you know why is that happening? May you please look into it? Thanks!

@maurolepore
Copy link
Contributor

All seems good now. The last commit on main passes all checks green.

@kalashsinghal
Copy link
Collaborator Author

@maurolepore Thanks for checking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolepore maurolepore Awaiting requested review from maurolepore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding GEO column to emission_profile_upstream and sector_profile_upstream at product level
2 participants
@kalashsinghal @maurolepore