Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GEO column to emission_profile_upstream and sector_profile_upstream at product level #119

Closed
AnneSchoenauer opened this issue Jan 4, 2024 · 6 comments · Fixed by #148
Assignees
Labels
enhancement New feature or request

Comments

@AnneSchoenauer
Copy link

Would be great to add the GEO column per input_product. Thanks!

@kalashsinghal
Copy link
Collaborator

@AnneSchoenauer What's the name of GEO column should be? Does ei_input_geography sound good?

@AnneSchoenauer
Copy link
Author

@kalashsinghal how is the geo column called on product level? If it is ei_geography. I think the ei_input_geography would work fine!

@kalashsinghal
Copy link
Collaborator

@AnneSchoenauer The geo column is not present in the product level result. Hence, I will add it through the ei_input_data file, which is used to add other columns. I forgot to mention that the column name is input_geography in this file. Is it still ok to keep the column name as ei_input_geogrphy?

@AnneSchoenauer
Copy link
Author

@kalashsinghal it would also be great to add the geo column in the product dataset. So it would be ei_geography and ei_input_geograhy. Thanks :)

@kalashsinghal
Copy link
Collaborator

@AnneSchoenauer Just to be 100% clear, We can add ei_geography column in emission_profile and sector_profile at product level, and we can add both ei_geography and ei_input_geography in emission_profile_upstream and sector_profile_upstream at product level (as they have both main products and input products). Should I add geography columns in all the four indicators in the way I described?

@AnneSchoenauer
Copy link
Author

@kalashsinghal yes exactly :) Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants