Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename output columns #137

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Rename output columns #137

merged 5 commits into from
Jan 17, 2024

Conversation

kalashsinghal
Copy link
Collaborator

@kalashsinghal kalashsinghal commented Jan 15, 2024

closes #118

Dear @SKruthoff @ysherstyuk @maurolepore

I have renamed some output columns which completes this issue. However, I have made the renaming function backward compatible, so that @SKruthoff @ysherstyuk you both can still use the old column names. To use the backward compatibility feature, you can use this line of code: options(tiltIndicatorAfter.dissable_issue_118 = TRUE) to disable this change. Here is how you can do it:

  library(tiltIndicatorAfter)
  
  # Please call this line of code before applying the `profile_emissions` function from tiltIndicatorAfter 
  options(tiltIndicatorAfter.dissable_issue_118 = TRUE)
  output <- profile_emissions(companies,
                              co2,
                              europages_companies,
                              ecoinvent_activities,
                              ecoinvent_europages,
                              isic)

Please let me know of any questions! Thanks!


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@kalashsinghal kalashsinghal marked this pull request as draft January 15, 2024 13:23
@kalashsinghal kalashsinghal marked this pull request as ready for review January 16, 2024 08:51
maurolepore
maurolepore previously approved these changes Jan 16, 2024
Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please see my comments.

@kalashsinghal kalashsinghal merged commit a8f6fdc into main Jan 17, 2024
7 checks passed
@kalashsinghal kalashsinghal deleted the 118_rename_output_columns branch January 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming output columns
2 participants