Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export epa_at_company_level() and insert_row_with_na_in_risk_category() #795

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

kalashsinghal
Copy link
Collaborator

@kalashsinghal kalashsinghal commented Jun 14, 2024

Relates to issue

Dear @maurolepore,

I have to use the epa_at_company_level() and insert_row_with_na_in_risk_category() to assign risk categories to transition risk scores at company level. I will export this function to tiltIndicatorAfter. Please review! Thanks!


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR description to reflect what it ended up doing.
  • Polish the PR title as you'd like others to read it from the git log.
  • Assign a reviewer.
  • Document user-facing changes in the changelog.

@kalashsinghal kalashsinghal changed the title Export epa_at_company_level Export epa_at_company_level and insert_row_with_na_in_risk_category Jun 14, 2024
@kalashsinghal kalashsinghal changed the title Export epa_at_company_level and insert_row_with_na_in_risk_category Export epa_at_company_level() and insert_row_with_na_in_risk_category() Jun 14, 2024
@maurolepore
Copy link
Contributor

LGTM.

@kalashsinghal kalashsinghal merged commit 0059ead into main Jun 14, 2024
8 checks passed
@kalashsinghal kalashsinghal deleted the 256_export_epa_at_company_level branch June 14, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants