Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check why some companies_id have NA in country in tiltIndicatorBefore #744

Closed
Tilmon opened this issue Mar 12, 2024 · 1 comment
Closed
Assignees

Comments

@Tilmon
Copy link
Contributor

Tilmon commented Mar 12, 2024

(This should be in tiltIndicatorBefore but I can't transfer it to that repo for some reason, so pls do it yourself)

Hi @kalashsinghal ,

Mauro found in this comment https://github.com/2DegreesInvesting/tiltOutput/issues/1#issuecomment-1991633387 that there are some companies_id with NA in country. This shouldn't be the case, as in tiltData every companies_id has a corresponding country.

Can you pls check where this originates from?

Thanks!

cc' @AnneSchoenauer @maurolepore

@maurolepore
Copy link
Contributor

@Tilmon see https://github.com/2DegreesInvesting/tiltOutput/issues/1#issuecomment-1991814366

I think the important country column (with no NAs) is passed to tiltIndicatorAfter via the argument europages_companies -- not via the argument companies.

I'll assume my comment solves this issue (if anything what needs to be done is to remove the confusing country column from the companies dataset).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants