Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename R/ and tests/ files for sector_profile_any_pivot_type_sector_subsector() #371

Open
maurolepore opened this issue May 30, 2023 · 2 comments
Open

Rename R/ and tests/ files for sector_profile_any_pivot_type_sector_subsector() #371

maurolepore opened this issue May 30, 2023 · 2 comments
Assignees
@maurolepore

Comments

@maurolepore
Copy link
Contributor

maurolepore commented May 30, 2023 •
edited
Loading

I see sector_profile_any_pivot_type_sector_subsector() does a lot more than just pivoting so I think the more general name sector_profile_any_prepare_companies() better reflects its intent.

@kalashsinghal, what do you think?
@maurolepore maurolepore self-assigned this May 30, 2023
@maurolepore maurolepore changed the title Rename to xstr_prepare_companies()? Rename to xstr_prepare_companies()? May 30, 2023
@maurolepore maurolepore added question Further information is requested bug Something isn't working and removed bug Something isn't working question Further information is requested labels May 30, 2023
@maurolepore maurolepore changed the title Rename to xstr_prepare_companies()? Rename to xstr_prepare_companies() May 30, 2023
@maurolepore maurolepore mentioned this issue May 30, 2023
Merged
11 tasks
@kalashsinghal
Copy link
Collaborator

Dear @maurolepore,

xstr_pivot_type_sector_subsector() function is used for companies dataset in PSTR and is used for inputs dataset in ISTR. Hence, the name xstr_prepare_companies() is not appropriate to use for inputs dataset in the case of ISTR. Do you agree?

@maurolepore maurolepore changed the title Rename to xstr_prepare_companies() Rename files to xstr_pivot_type_sector_subsector() May 31, 2023
@maurolepore
Copy link
Contributor Author

Great point, thanks!
I changed the title of this issue to instead rename the R/ and tests/ files accordingly.

@maurolepore maurolepore changed the title Rename files to xstr_pivot_type_sector_subsector() Rename R/ and tests/ files that host xstr_pivot_type_sector_subsector() May 31, 2023
@maurolepore maurolepore changed the title Rename R/ and tests/ files that host xstr_pivot_type_sector_subsector() Rename R/ and tests/ files for xstr_pivot_type_sector_subsector() May 31, 2023
@maurolepore maurolepore changed the title Rename R/ and tests/ files for xstr_pivot_type_sector_subsector() Rename R/ and tests/ files for sector_profile_any_pivot_type_sector_subsector() Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolepore maurolepore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maurolepore @kalashsinghal