Test sector*()
focusing on type
, sector
and subsector
#782
maurolepore
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Here is note and reprex to help myself more quickly and accurately understand analysts's comments, and write tests. In short, create test data focusing on the columns
type
,sector
, andsubsector
in the datasetscompanies
andscenarios
.--
I'm usually confused when I read comments that focus on the columns
tilt_sector
andtilt_subsector
, but then I realize that the role of these columns in the code is indirect.While
companies$tilt_sector and
companies$tilt_subsector are crucial conceptually (they relate to sector and subsector), they play no role in the computation. In the computation, the relevant columns arecompanies$type
,companies$sector
, andcompanies$subsector
– which yield different results depending on whether or not the values of these columns match or not the values ofscenarios$type
,scenarios$sector
, andscenarios$subsector
.reprex
Beta Was this translation helpful? Give feedback.
All reactions