From 7cff9bfe0fbe7e6088cf365880b7f460efa88dd2 Mon Sep 17 00:00:00 2001 From: Mauro Lepore Date: Sun, 12 Nov 2023 13:38:39 +0000 Subject: [PATCH] pass --- ...ons_profile_any_add_values_to_categorize.R | 4 ++++ tests/testthat/test-emissions_profile.R | 20 ++++++++++++------- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/R/emissions_profile_any_add_values_to_categorize.R b/R/emissions_profile_any_add_values_to_categorize.R index 28a0c6012..dce72f14e 100644 --- a/R/emissions_profile_any_add_values_to_categorize.R +++ b/R/emissions_profile_any_add_values_to_categorize.R @@ -23,6 +23,10 @@ #' inputs <- read_csv(toy_emissions_profile_upstream_products()) #' inputs |> emissions_profile_any_add_values_to_categorize() emissions_profile_any_add_values_to_categorize <- function(data) { + if (hasName(data, "values_to_categorize")) { + return(data) + } + benchmarks <- set_names(epa_benchmarks(data), flat_benchmarks(data)) map_df(benchmarks, ~ add_rank(data, .x), .id = "grouped_by") } diff --git a/tests/testthat/test-emissions_profile.R b/tests/testthat/test-emissions_profile.R index afc70022d..620f91dcb 100644 --- a/tests/testthat/test-emissions_profile.R +++ b/tests/testthat/test-emissions_profile.R @@ -54,13 +54,19 @@ test_that("it uses pre-computed `values_to_categorize` from 'co2' (#603)", { !!aka("co2footprint") := c(1, 2) ) - out <- emissions_profile(companies, co2) - computed <- unique(unnest_product(out)$risk_category) + lacks_values_to_categorize <- !hasName(co2, "values_to_categorize") + stopifnot(lacks_values_to_categorize) + out1 <- emissions_profile(companies, co2) + using_computed_values <- unique(unnest_product(out1)$risk_category) - pre_computed <- co2 - pre_computed$values_to_categorize <- c(999, 999) - out <- emissions_profile(companies, pre_computed) - pre_computed <- unique(unnest_product(out)$risk_category) + pre_computed <- emissions_profile_any_add_values_to_categorize(co2) + has_values_to_categorize <- hasName(pre_computed, "values_to_categorize") + stopifnot(has_values_to_categorize) - expect_false(identical(computed, pre_computed)) + yields_a_different_risk_category <- 999 + pre_computed$values_to_categorize <- yields_a_different_risk_category + out2 <- emissions_profile(companies, pre_computed) + using_pre_computed_values <- unique(unnest_product(out2)$risk_category) + + expect_false(identical(using_computed_values, using_pre_computed_values)) })