Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Merge" information inaccurate #2127

Open
nodunayo opened this issue Dec 5, 2017 · 4 comments
Open

"Merge" information inaccurate #2127

nodunayo opened this issue Dec 5, 2017 · 4 comments

Comments

@nodunayo
Copy link
Contributor

nodunayo commented Dec 5, 2017

馃悶 Problem

Just before 7pm today, I went onto the 24 Pull Requests website and I noticed my 'Merges' tab was missing:

screen shot 2017-12-05 at 18 57 32

I also noticed that I wasn't showing up here: https://24pullrequests.com/mergers.
The number of maintainers at that time read '80-something'.

30 minutes later I check back:

screen shot 2017-12-05 at 19 26 24
screen shot 2017-12-05 at 19 26 47

My 'Merges' tab is back and now there are 216 maintainers.

This wasn't the first time I've noticed my 'Merges' tab disappearing.

We need to discover what's happening and consistently show what merges have taken place during the challenge!

Anyone have any idea what's going on? Has this happened in previous years?

@nodunayo nodunayo added the bug label Dec 5, 2017
@nodunayo
Copy link
Contributor Author

nodunayo commented Dec 5, 2017

Steadily decreasing number of maintainers as I sit and refresh the page:

screen shot 2017-12-05 at 19 30 44]

One second later:

screen shot 2017-12-05 at 19 30 56

馃

@gep13
Copy link
Member

gep13 commented Dec 6, 2017

I would like to chime in on this issue...

I currently don't have a Merges tab at all, even though I know for a fact that I have merged PR's that have been created as part of the 24PullRequests effort.

Is there a reason that these are not appearing for me? Am I right in thinking that I should be appearing on this list: https://24pullrequests.com/mergers

Thanks

@nodunayo
Copy link
Contributor Author

nodunayo commented Dec 6, 2017

Yes, @gep13. It's likely part of the same bug. You should be appearing on that mergers page.

@andrew
Copy link
Member

andrew commented Dec 7, 2017

Definitely a bug, I've seen this going up and down over the past few days too.

I suspect that something is updating pull_requests and unsetting the merged_by_id attribute, so the merger looses the connection to that pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants