Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Redonner toute la hauteur au textarea de la preview de modules (PIX-12468) #8881

Closed
wants to merge 1 commit into from
Closed

[BUGFIX] Redonner toute la hauteur au textarea de la preview de modules (PIX-12468) #8881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mon-pix/app/styles/pages/_module-preview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@

.pix-textarea {
height: 100%;

div {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moui comme tu le dis, pas à l'aise avec ça. Mais d'ailleurs même .pix-textarea c'est pas tip top. Tu as réfléchi à quelque chose côté Pix UI pour permettre ça mais de manière propre ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, faudrait creuser pour comprendre l'usage de cette nouvelle div déjà.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On s'est dit avec @reibecca ça pourrait valoir le coup de tester l'attribut rows en "hotfix" avant de voir si on veut gérer cette complexité supplémentaire côté Pix UI

height: 100%;
}
}
}
}
Expand All @@ -37,4 +41,4 @@
&__textarea {
height: 100%;
}
}
}
Loading