Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black theme #73

Open
yephny opened this issue Dec 28, 2021 · 5 comments
Open

Black theme #73

yephny opened this issue Dec 28, 2021 · 5 comments
Labels

Comments

@yephny
Copy link

yephny commented Dec 28, 2021

Looking at the past issues, it seems like it was a trouble to implement a dark theme. Still, though, there are visual flavors to most apps and each has their own preference. Some prefer a light theme, some a dark theme like the one the app currently has, and I prefer black theme on all my apps. Apps like VocableTrainer unfortunately causes an inconsistency as they don't have a black theme option.

@0xpr03
Copy link
Owner

0xpr03 commented Dec 28, 2021

There is a dark theme, if you switch to dark theme in your android settings.

@yephny
Copy link
Author

yephny commented Dec 28, 2021

There is but I'm talking about amoled black.

@0xpr03
Copy link
Owner

0xpr03 commented Dec 28, 2021

That sounds like an entirely different thing. I seem to have an amoled display, but I'm not sure what you mean with a theme for that.

@yephny
Copy link
Author

yephny commented Dec 28, 2021

That's just an arbitrary name. A black or pitch/amoled/true black theme has #000000 as its background and uses #000000 whenever there is a dark shade.

Examples include

  • Pulse Music
    pulse

  • Material Files
    mat

  • Newpipe

newp

in comparison to OctoDroid's dark theme
octod

@0xpr03
Copy link
Owner

0xpr03 commented Dec 28, 2021

Ok, if you want you can make a PR for theming or maybe change the current black theme. It's currently not very high on the list of todos.

@0xpr03 0xpr03 added the feature label Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants