Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccountTree and PartialAccountTree #1157

Open
PhilippGackstatter opened this issue Feb 17, 2025 · 0 comments
Open

Add AccountTree and PartialAccountTree #1157

PhilippGackstatter opened this issue Feb 17, 2025 · 0 comments
Milestone

Comments

@PhilippGackstatter
Copy link
Contributor

What should be done?

Add types for AccountTree and PartialAccountTree to miden-base.

How should it be done?

We have to migrate from SimpleSmt to Smt as the underlying data structure used for the account tree, and we should probably add strongly-typed wrappers for these instead of using bare Smts (like we do in MockChain, for example).

When is this task done?

When the above structures are implemented and the places where we use them are updated, which includes at least:

  • MockChain
  • LocalBlockProver

Simple unit tests can be considered for them, but they are mostly tested as part of LocalBlockProver, so this seems somewhat optional.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants