Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bundled modules #2

Open
fabaff opened this issue May 18, 2020 · 2 comments
Open

Remove the bundled modules #2

fabaff opened this issue May 18, 2020 · 2 comments

Comments

@fabaff
Copy link
Contributor

fabaff commented May 18, 2020

The directory contains part of other Python modules. This should be removed and the modules in question mentioned as requirement.

This is an issue for the packaging. I will have a hard time to explain to the reviewer why the modules are shipped as part of dumpall when they are available from PyPI.

Thanks

@0xHJK
Copy link
Owner

0xHJK commented May 19, 2020

Thanks for your suggestion.

But the dsstore.py in directory is not available from PyPI.
https://github.com/gehaxelt/Python-dsstore

gin is available from PyPI, but it couldn't to use as module.
To use the script as a module, should rename it to gin.py.
https://github.com/sbp/gin#advanced

@fabaff
Copy link
Contributor Author

fabaff commented May 24, 2020

Thanks for providing some more details. Uff, let me think about it.

gin was not touch in 7 years. I guess that there will be not much action. In a worst case scenario I have to detail with it and mark it as bundled in the Fedora package.

Let me get in touch with @gehaxelt. Perhaps is there a way to make dsstore available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants