-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom block type per blacklist group #1419
Comments
Sounds reasonable even if you're idea would most likely end up in an SSL warning page since almost all requests are done with HTTPS and even if your warning page has a correct certificate it wouldn't match with the requested URL. |
Yes, I'm aware that incorrect certificate might be an issue but IMO this is better than generic error. On the other hand, it really depends on the implementation of the URL redirection on the http://123.123.123.123 ? |
Depends on your use case since most users get suspicious at SSL errors. It might be possible to set up SSL man-in-the-middle to combat those but this is really painful and most likely isn't beneficial for your user experience. |
I don't care much about adware and in that case
zeroIP
ornxDomain
response is good enough. But for malware&co I do want to have a custom IP redirect where a warning message for the mentioned page is displayed.Would it be possible to refactor the
blockType
to support different response options per blacklist group? For example, the config would be like:The text was updated successfully, but these errors were encountered: