Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add edit code with VSCode button to repository code page #188

Closed
1 task done
dovatti opened this issue Jun 21, 2022 · 15 comments
Closed
1 task done

Feature: Add edit code with VSCode button to repository code page #188

dovatti opened this issue Jun 21, 2022 · 15 comments
Assignees
Labels
good first issue The author's first issue. type/feature-request This issue is a feature request.

Comments

@dovatti
Copy link

dovatti commented Jun 21, 2022

Before you start...

  • Have you checked if a similar feature request has already been reported?

Description

Simplest idea: integrate a magnet button to open system default text-editor (Visual Studio Code, Atom, Sublime Text, etc etc).

Alternative solutions

In addition to that, we could integrate vscode.dev inside a chromium instance so final user can code directly inside FluentHub: for example, if I just had to add a link to README.md of an awesome-list, I'll click on "Edit in FluentHub" (or something similar), code and pull.

I can help you for both ideas.

Relevant Assets

No response

@dovatti dovatti added the type/feature-request This issue is a feature request. label Jun 21, 2022
@0x5bfa 0x5bfa added the triage/needs-more-info This issue/PR needs more infomation. label Jun 21, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Jun 21, 2022

Want to add "Edit in FluentHub" like vscode.dev in your browser and create something similar to text editor into FluentHub?

@0x5bfa
Copy link
Owner

0x5bfa commented Jun 21, 2022

If so, it's a good idea. but the goal up to version v0.5 is to make all queries work correctly and with as few bugs as possible. The goal up to v0.9 is to make all mutations work correctly and with as few bugs as possible. We will also do a final check to migrate all Alpha phase features to Stable by v1.

This feature may be considered after v0.5. For now, we have no plans to create a feature to change GitHub data (called Mutation) such as editing user profile and editing a blob.

@dovatti
Copy link
Author

dovatti commented Jun 21, 2022

I was talking about adding an integrated instance of vscode.dev inside FluentHub.
If you wants, I could develop it, pull a request and wait until v1. Meanwhile waiting I could help on bug fixes.

@0x5bfa
Copy link
Owner

0x5bfa commented Jun 21, 2022

Just don't modify GitHub data? I don't know what “integrated instance” was.

@dovatti
Copy link
Author

dovatti commented Jun 21, 2022

Just don't modify GitHub data? I don't know what “integrated instance” was.

I think you should read this, it is ofc more specific than me.
For integrated instance I mean I would like to have a page like vscode.dev inside FluentHub.
I think we're talking about the same thing but with different synonyms. 😁

@0x5bfa
Copy link
Owner

0x5bfa commented Jun 21, 2022

Ah, when clicking the edit button, the app opens WebView2 windows with vscode.dev?

@dovatti
Copy link
Author

dovatti commented Jun 21, 2022

Yep. Or with installed text-editor inside OS where is running FluentHub.
i.e: I've got Windows 11 and Sublime Text, I can choose between integrated editor (via WebView2 with vscode.dev etc, etc...) or opening in a new window inside my installed editor (like an "Open in" context menu).
The last part is easier than first to implement. It simply link via an editor.JSON file (or whatever name we want to give it) installed text-editors.

@0x5bfa
Copy link
Owner

0x5bfa commented Jun 21, 2022

Got it. It is a good idea! if you can open a PR, please do.

you think it is something like this, right?

image

@dovatti
Copy link
Author

dovatti commented Jun 21, 2022

Exactly! If is okay for you, I'll work on it soon!

@0x5bfa 0x5bfa added good first issue The author's first issue. Pri: low and removed triage/needs-more-info This issue/PR needs more infomation. labels Jun 21, 2022
@Lamparter
Copy link
Collaborator

Wait just to make things clear.. @onein528 you want to add WebView2 with github.dev page to FH?

@0x5bfa
Copy link
Owner

0x5bfa commented Jul 3, 2022

No this feature request is not like that.
just open github.dev with browser.

@Lamparter
Copy link
Collaborator

No this feature request is not like that. just open github.dev with browser.

oh. Can't we use WebView? @onein528

@0x5bfa
Copy link
Owner

0x5bfa commented Jul 3, 2022

can use. but he not meant to. @dovatti How about?

@dovatti
Copy link
Author

dovatti commented Jul 3, 2022

Not yet. I think this will take some time to start working on if alone. @DeveloperWOW64 if you would like to implement that would be great, I would help in my free time. I do work every day so I do not have too much spare time.

@stale stale bot added the wontfix label Jul 18, 2022
@0x5bfa 0x5bfa removed the wontfix label Jul 19, 2022
@dovatti
Copy link
Author

dovatti commented Jul 19, 2022

@onein528 @DeveloperWOW64 I've got some news: I've been coding according to these guide and essentially got code working.
Currently could be possible to get an "Open in VSCode.dev" button and open the web page inside FluentHub. But I was thinking: does exist an "official" pattern/model to achieve that? I think more than one person in UWP community would like to integrate WebView2 already wrapped with it's own UI. If so we could use this coding pattern instead of my code monster 😆
Otherwise, I've been already thinking about a Fluent wrapper for VSCode UI; but I do not think would be perfect as I want.

I'll release soon all the project folder with schemas, graphs and resources, and obviously with code working for WebView at least. Don't know when because I've been working and studying very hard this months 👍🏻

@0x5bfa 0x5bfa changed the title Direct text-editor integration Add edit code with VSCode button to repository code page Aug 22, 2022
@0x5bfa 0x5bfa added this to the FluentHub v0.5 milestone Aug 22, 2022
Repository owner deleted a comment from stale bot Sep 4, 2022
@0x5bfa 0x5bfa mentioned this issue Sep 16, 2022
1 task
@0x5bfa 0x5bfa changed the title Add edit code with VSCode button to repository code page Feature: Add edit code with VSCode button to repository code page Feb 10, 2023
@0x5bfa 0x5bfa self-assigned this Jul 31, 2023
@0x5bfa 0x5bfa closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue The author's first issue. type/feature-request This issue is a feature request.
Projects
None yet
Development

No branches or pull requests

3 participants