Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an abstract layer to support pydantic[v1]/pydantic[v2]/msgspec #329

Open
kemingy opened this issue Jul 27, 2023 · 0 comments
Open

feat: add an abstract layer to support pydantic[v1]/pydantic[v2]/msgspec #329

kemingy opened this issue Jul 27, 2023 · 0 comments
Assignees
@kemingy

Comments

@kemingy
Copy link
Member

kemingy commented Jul 27, 2023

Pydantic v2 has too many breaking changes that lots of 3rd libraries are not able to upgrade in a short time.

This PR is not backward compatible (due to pydantic breaking changes). I'm not sure if we should make this library compatible with both pydantic v1 & v2. Or maybe we should add another abstract layer so that we can make it possible to support pydantic v1 & v2 and msgspec (ref #307)

Originally posted by @kemingy in #319 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kemingy kemingy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kemingy