Skip to content

Commit e5b12be

Browse files
committed
Add py36 environment to CI and fix test
test_predeactivate_hook fails on py36 because tmpdir (py.local) now implements the __path__ protocol so it the call to open inside nodeenv.set_predeactivate_hook actually goes through but fails with an FileNotFoundError
1 parent 6c26975 commit e5b12be

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ env: # These should match the tox env list
55
- TOXENV=py33
66
- TOXENV=py34
77
- TOXENV=py35
8+
- TOXENV=py36
89
- TOXENV=pypy
910
install: pip install coveralls tox
1011
script: tox

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ def read_file(file_name):
5454
'Programming Language :: Python :: 3.3',
5555
'Programming Language :: Python :: 3.4',
5656
'Programming Language :: Python :: 3.5',
57+
'Programming Language :: Python :: 3.6',
5758
'Programming Language :: Python :: Implementation :: CPython',
5859
'Programming Language :: Python :: Implementation :: PyPy',
5960
'Topic :: Software Development :: Libraries :: Python Modules'

tests/nodeenv_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def test_print_node_versions_node(cap_logging_info):
146146
def test_predeactivate_hook(tmpdir):
147147
# Throw error if the environment directory is not a string
148148
with pytest.raises((TypeError, AttributeError)):
149-
nodeenv.set_predeactivate_hook(tmpdir)
149+
nodeenv.set_predeactivate_hook(1)
150150
# Throw error if environment directory has no bin path
151151
with pytest.raises((OSError, IOError)):
152152
nodeenv.set_predeactivate_hook(tmpdir.strpath)

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tox]
22
# These should match the travis env list
3-
envlist = py27,py33,py34,py35,pypy
3+
envlist = py27,py33,py34,py35,py36,pypy
44

55
[testenv]
66
install_command = pip install --use-wheel {opts} {packages}

0 commit comments

Comments
 (0)